Fix some RISC-V ABI issues and add ILP32/LP64 (soft float) to module tests #21610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Rexicon226 |
alexrp
commented
Oct 6, 2024
| .{ | ||
| .target = std.Target.Query.parse(.{ | ||
| .arch_os_abi = "riscv32-linux-none", | ||
| .cpu_features = "baseline-d-f", |
There was a problem hiding this comment.
(The plan is for this to become a proper ABI in std.Target with #20690.)
Rexicon226
approved these changes
Oct 7, 2024
linusg
reviewed
Oct 8, 2024
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I'm not adding ILP32F/LP64F (hard
f32, softf64) to the test matrix. They work, but they're used extremely rarely, so I don't think it's worth wasting valuable CI resources on them. For perspective, glibc doesn't support them, and musl needs a patch for them to work, so I doubt anyone cares much.