std.debug: Remove MemoryAccessor and simplify use sites.
#23586
Conversation
alexrp
force-pushed
the
no-memory-accessor
branch
from
f1e9ac9 to
ede2083
Compare
|
Will revisit this if I figure out a way to repro the |
|
what was the failure and why delete the branch? |
| const num_restored_pairs: usize = | ||
| @popCount(@as(u5, @bitCast(encoding.value.arm64.frame.x_reg_pairs))) + | ||
| @popCount(@as(u4, @bitCast(encoding.value.arm64.frame.d_reg_pairs))); | ||
| const min_reg_addr = fp - num_restored_pairs * 2 * @sizeOf(usize); | ||
|
|
||
| if (ma.load(usize, new_sp) == null or ma.load(usize, min_reg_addr) == null) return error.InvalidUnwindInfo; |
There was a problem hiding this comment.
what does this change have to do with MemoryAccessor?
edit: looks like they were temporaries only needed for the ma.load expression
There was a problem hiding this comment.
MemoryAccessor.load() only returns null if the pointer is invalid, i.e. a regular load would have segfaulted. This is a defensive check that can only exist because of MemoryAccessor.
I think it was some unwind issue that manifested as a segfault on native aarch64-linux, and I don't have a machine available to debug that. Of course GitHub helpfully deleted the logs: https://github.com/ziglang/zig/actions/runs/14501073544
I wasn't expecting to get around to this anytime soon due to the above. The changes are just the result of deleting |
|
=> #24960 |
2 participants
Let's see what CI has to say.