Skip to content

Conversation

andrewrk
Copy link
Member

This API is based around the unsound idea that a process can perform checked virtual memory loads to prevent crashing. This depends on OS-specific APIs that may be unavailable, disabled, or impossible due to virtualization.

It also makes collecting stack traces ridiculously slow, which is a problem for users of DebugAllocator - in other words, everybody, all the time. It also makes strace go from being superbly clean to being awful.

@andrewrk
Copy link
Member Author

Local failures:

$ stage3/bin/zig build test-std -Dskip-release -fwasmtime -fqemu
test-std
└─ run test std-powerpc64-linux-none-ppc64-Debug failure
Segmentation fault at address 0x0
qemu: uncaught target signal 6 (Aborted) - core dumped
error: while executing test 'array_hash_map.test.shrink', the following command terminated with signal 6 (expected exited with code 0):
qemu-ppc64 /home/andy/src/zig/.zig-cache/o/f7fde40a630566a8d8c8f778867a1e45/test --cache-dir=/home/andy/src/zig/.zig-cache --seed=0x11856a21 --listen=-
[232/238] steps
├─ [1434/2943] run test std-mips64el-linux-muslabi64-mi
│  └─ http.test.test.echo content server
├─ [1434/2943] run test std-mipsel-linux-musleabi-mips3
│  └─ http.test.test.echo content server
├─ [1434/2943] run test std-mipsel-linux-eabihf-mips32r
│  └─ http.test.test.echo content server
├─ [1435/2944] run test std-riscv64-linux-musl-baseline
│  └─ http.test.test.echo content server
└─ [1434/2943] run test std-mips64el-linux-none-mips64r
   └─ http.test.test.echo content server

The jobs shown currently running are deadlocked.

This API is based around the unsound idea that a process can perform
checked virtual memory loads to prevent crashing. This depends on
OS-specific APIs that may be unavailable, disabled, or impossible due to
virtualization.

It also makes collecting stack traces ridiculously slow, which is a
problem for users of DebugAllocator - in other words, everybody, all the
time. It also makes strace go from being superbly clean to being awful.
@andrewrk andrewrk merged commit 83f773f into master Aug 24, 2025
14 checks passed
@andrewrk andrewrk deleted the MemoryAccessor branch August 24, 2025 01:54
@alexrp
Copy link
Member

alexrp commented Aug 24, 2025

What was up with these:

[232/238] steps
├─ [1434/2943] run test std-mips64el-linux-muslabi64-mi
│  └─ http.test.test.echo content server
├─ [1434/2943] run test std-mipsel-linux-musleabi-mips3
│  └─ http.test.test.echo content server
├─ [1434/2943] run test std-mipsel-linux-eabihf-mips32r
│  └─ http.test.test.echo content server
├─ [1435/2944] run test std-riscv64-linux-musl-baseline
│  └─ http.test.test.echo content server
└─ [1434/2943] run test std-mips64el-linux-none-mips64r
   └─ http.test.test.echo content server

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants