Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client developer may use packaged fixtures when integrating Compensated #68

Open
4 of 12 tasks
jalcine opened this issue May 10, 2020 · 3 comments
Open
4 of 12 tasks
Labels
code Work that will require some amount of programming documentation Work that is intended to focus on improving documentation enhancement New feature or request epic Work that will will likely cover a number of use cases. test Work that will require testing skillz
Milestone

Comments

@jalcine
Copy link

jalcine commented May 10, 2020

Currently, the core compensated library holds a lot of useful code around the fixtures for testing responses from Stripe and Apple Pay. Moving them into a separate library (ideally compensated-spec) will allow any other Compensated gem to use them and share changes upstream. This can be also be used by other projects that want to test how Compensated responds to particular events.

Feature Definition

Feature: Spec Fixtures
  In order to more easily test how payment processor events will impact my system
  As a Client Developer
  I want to be able to apply payment gateway event fixtures in my automated test suite

This Issue May Be Closed When

@zspencer zspencer changed the title Extract Spec Helpers for Compensated Client developer may use packaged fixtures when integrating Compensated May 11, 2020
@zspencer zspencer added code Work that will require some amount of programming documentation Work that is intended to focus on improving documentation enhancement New feature or request epic Work that will will likely cover a number of use cases. test Work that will require testing skillz labels May 11, 2020
@zspencer zspencer added this to the 0.1.0 milestone May 11, 2020
@zspencer
Copy link
Member

@jalcine - nice! I've updated the issue body to add some acceptance criteria and sprout a feature definition.

I think this is a pretty big chunk of work (likely exceeding our "4 hour timebox") so I've added the epic label.

As a thank you for taking the time to put this issue together, I've transferred you 20 points from my personal patronage account balance. These points are worthless for now, but may be redeemed for a share of the profits generated by Zinc (you know, once we have them :)).

zspencer added a commit that referenced this issue May 21, 2020
One of the big challenges for working with using compensated is a lack
of clarity on
what the actual data structure coming out will look like.

This gives client developers a tool to programmatically verify their implementation by
firing raw events from payment processors through their compensated implementation.

See: #68
@zspencer
Copy link
Member

@jalcine - Do you think this is kind of where you want this to be headed: #72

The goal here is to make it possible for you to generate events from any of the payment processors we support and throw them at a compensated-proxy or a ruby project that is using the compensated gem so you can programmatically test scenarios without having to assemble the fixtures yourself.

Thoughts?

@jalcine
Copy link
Author

jalcine commented May 22, 2020

@jalcine - Do you think this is kind of where you want this to be headed: #72

The goal here is to make it possible for you to generate events from any of the payment processors we support and throw them at a compensated-proxy or a ruby project that is using the compensated gem so you can programmatically test scenarios without having to assemble the fixtures yourself.

This satisfies the needs I'll have when wanting to incorporate Compensated!

user512 pushed a commit that referenced this issue Jun 1, 2020
* 🌱🎉Sprout compensated-spec project for fixtures

One of the big challenges for working with using compensated is a lack
of clarity on
what the actual data structure coming out will look like.

This gives client developers a tool to programmatically verify their implementation by
firing raw events from payment processors through their compensated implementation.

See: #68
zspencer added a commit that referenced this issue Jun 18, 2020
user512 pushed a commit that referenced this issue Jun 18, 2020
…nsated-proxy` (#83)

* 🐛Don't double dump the hash structures

See: #68

* `compensated` relies on `compensated-spec` for Stripe test fixtures

See: #68

* Rely on `compensated-spec` in `compensated-proxy` for event fixtures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Work that will require some amount of programming documentation Work that is intended to focus on improving documentation enhancement New feature or request epic Work that will will likely cover a number of use cases. test Work that will require testing skillz
Projects
None yet
Development

No branches or pull requests

2 participants