Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱🎉Sprout compensated-spec project for fixtures #72

Merged
merged 6 commits into from
Jun 1, 2020

Conversation

zspencer
Copy link
Member

One of the big challenges for working with using compensated is a lack
of clarity on
what the actual data structure coming out will look like.

This gives client developers a tool to programmatically verify their implementation by
firing raw events from payment processors through their compensated implementation.

See: #68

One of the big challenges for working with using compensated is a lack
of clarity on
what the actual data structure coming out will look like.

This gives client developers a tool to programmatically verify their implementation by
firing raw events from payment processors through their compensated implementation.

See: #68
@zspencer zspencer requested a review from a team May 21, 2020 19:24
@zspencer
Copy link
Member Author

@user512 / @lanegrant - Does this look like it's a "good enough" step to consider merging so that we can move forward piece-by-piece on the specification? I want to make sure we're integrating the work we do on the regular so that it's easy to build on top of one anothers work, but I also don't want to put something into the repo if it's just going to get in the way.

Thoughts?

@zspencer zspencer marked this pull request as ready for review May 29, 2020 16:48
@zspencer
Copy link
Member Author

Phew! I think I got this working!

Essentially you can mixin Compensated::Spec::Helpers into your test suite, and then you can call the methods defined on it to generate fake requests, event body payloads, etc; and replace data within them using the JsonSpec syntax.

This should make it much easier for folks to write tests for their compensated integration.

@lanegrant / @user512 - Mind giving this a review? The fixture files themselves aren't particularly interesting.

Copy link
Contributor

@user512 user512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and I think I will get a better understand when using it.

@user512 user512 merged commit c1afca3 into 0.X Jun 1, 2020
@user512 user512 deleted the spec/sprout-compensated-spec branch June 1, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants