Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ₯”βœ¨ Spaces: New Space Onboarding! #1585

Open
4 of 5 tasks
Tracked by #1154
KellyAH opened this issue Jun 22, 2023 · 5 comments
Open
4 of 5 tasks
Tracked by #1154

πŸ₯”βœ¨ Spaces: New Space Onboarding! #1585

KellyAH opened this issue Jun 22, 2023 · 5 comments
Labels
✨ feature Reduces Client's Burden or Grants them Benefits πŸ₯” Satisfices It's good enough to use, but not particularly great

Comments

@KellyAH
Copy link
Contributor

KellyAH commented Jun 22, 2023

Use Cases

  • πŸ₯”βœ¨ Prompt to add Members
  • πŸ₯”βœ¨ Prompt to add Section
  • πŸ₯”βœ¨ Prompt to set Entrance
  • πŸ₯”βœ¨ Prompt to set Gizmo for entrance missing a Gizmo ✨Space: Prompt to add Gizmo to Entrance Β #1593
  • πŸ₯”βœ¨ Better handle when a Space does not have an Entrance (or make it impossible to get into a state where the Space does not have an Entrance if it has rooms)
@KellyAH KellyAH self-assigned this Jun 22, 2023
@KellyAH KellyAH changed the title Spaces Configure Space page should display helpful setup prompts ✨ Spaces Configure Space page should display helpful setup prompts Jun 22, 2023
@KellyAH KellyAH closed this as completed Jun 22, 2023
@zspencer zspencer changed the title ✨ Spaces Configure Space page should display helpful setup prompts ✨ Spaces: New Space Onboarding! Jun 22, 2023
@zspencer zspencer added ✨ feature Reduces Client's Burden or Grants them Benefits πŸ₯” Satisfices It's good enough to use, but not particularly great labels Jun 22, 2023
@zspencer zspencer reopened this Jun 22, 2023
@zspencer
Copy link
Member

Thank you @KellyAH !!! I think we're going to want to keep this issue around to start adding improvements to the full Space onboarding flow; I've added one more Use Case: We should presume that if the Space has a Section, that Section is the Entrance to the Space.

@zspencer zspencer changed the title ✨ Spaces: New Space Onboarding! πŸ₯”βœ¨ Spaces: New Space Onboarding! Jun 22, 2023
@zspencer
Copy link
Member

@KellyAH what do you think about adding a prompt when the current room doesn’t have any gizmos?

@KellyAH
Copy link
Contributor Author

KellyAH commented Jun 24, 2023

@KellyAH what do you think about adding a prompt when the current room doesn’t have any gizmos?

I'll add that in a new PR

@KellyAH
Copy link
Contributor Author

KellyAH commented Jun 29, 2023

Automatically presume the only Section is the Entrance

What does this mean exactly? There can be multiple sections. What am I supposed to build?

@zspencer
Copy link
Member

zspencer commented Jul 5, 2023

Automatically presume the only Section is the Entrance

What does this mean exactly? There can be multiple sections. What am I supposed to build?

The problem I am trying to solve is there is a blank screen when a Space has a Section but Space#entrance is not set. I think the way to resolve that could go down several pathways:

  • We could adjust what happens when a Section is created in a Space with no Sections yet to also set the new Section as the Space#entrance
  • We could override Space#entrance (perhaps implementing it as super.presence || sections.first or something); so that if there are any Sections in the Space it at least has a quasi-entrance.
  • ???

You will likely need to explore both pathways a little bit (or come up with your own 3rd pathway) before making the call about which is easiest for you to make happen. My instincts are overloading the Space#entrance method is easiest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature Reduces Client's Burden or Grants them Benefits πŸ₯” Satisfices It's good enough to use, but not particularly great
Projects
None yet
Development

No branches or pull requests

2 participants