🌸✨ Marketplace: Begin to smooth out Onboarding
#1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #1641 This starts us off with products and delivery areas; but we should probably do taxes and some other bits too...
zspencer
force-pushed
the
marketplace/warn-when-the-marketplace-is-missing-order-notifications
branch
from
3dece53
to
6338c58
Compare
zspencer
changed the title
Marketplace: Begin to smooth out OnboardingMarketplace: Begin to smooth out Onboarding
zspencer
changed the title
Marketplace: Begin to smooth out OnboardingMarketplace: Begin to smooth out Onboarding
…sing-order-notifications
Comment on lines
13
to
24
| it { is_expected.to have_content(t(".title")) } | ||
| it { is_expected.to have_content(t(".marketplace_hidden", link: t("marketplace.marketplace.edit.link_to"))) } | ||
| it { is_expected.to have_link(t("marketplace.marketplace.edit.link_to"), href: polymorphic_path(marketplace.location(:edit))) } | ||
|
|
||
| it { is_expected.to have_content(t(".missing.notification_methods", link: t("marketplace.notification_methods.new.link_to"))) } | ||
| it { is_expected.to have_link(t("marketplace.notification_methods.new.link_to"), href: polymorphic_path(marketplace.location(:new, child: :notification_method))) } | ||
|
|
||
| it { is_expected.to have_content(t(".missing.products", link: t("marketplace.products.new.link_to"))) } | ||
| it { is_expected.to have_link(t("marketplace.products.new.link_to"), href: polymorphic_path(marketplace.location(:new, child: :product))) } | ||
|
|
||
| it { is_expected.to have_content(t(".missing.delivery_areas", link: t("marketplace.delivery_areas.new.link_to"))) } | ||
| it { is_expected.to have_link(t("marketplace.delivery_areas.new.link_to"), href: polymorphic_path(marketplace.location(:new, child: :delivery_area))) } |
There was a problem hiding this comment.
This is the "first half of the happy-path" towards getting people to add the related items to their marketplace. This still needs the second half at some point.
There was a problem hiding this comment.
Great point, will add the "What happens when it's fully configured? side of things.
daltonrpruitt
approved these changes
Jul 9, 2023
zspencer
deleted the
marketplace/warn-when-the-marketplace-is-missing-order-notifications
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marketplace: OnboardingVendors! #1641This follows the patterns @KellyAH set in #1585 to:
MarketplaceManagementComponent, so they're everywhere!After
Before