Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🥔⛰️ Space #1154

Closed
10 of 12 tasks
zspencer opened this issue Mar 2, 2023 · 1 comment
Closed
10 of 12 tasks

🥔⛰️ Space #1154

zspencer opened this issue Mar 2, 2023 · 1 comment
Labels
⛰️ epic Work we expect will take multiple patches to complete
Milestone

Comments

@zspencer zspencer added the ⛰️ epic Work we expect will take multiple patches to complete label Mar 2, 2023
@zspencer zspencer added this to the 1.0 - Andromeda milestone Mar 2, 2023
@zspencer zspencer changed the title Spaces 🥔Spaces Mar 2, 2023
@zspencer zspencer mentioned this issue Mar 2, 2023
8 tasks
zspencer added a commit that referenced this issue Mar 2, 2023
- #1154

Turns out, we had never exposed an affordance for setting the Space
entrance! Whoopsie-doodle!

Co-authored-by: Dalton Pruitt <daltonrpruitt@users.noreply.github.com>
Co-authored-by: Kelly Hong <KellyAH@users.noreply.github.com>
zspencer added a commit that referenced this issue Mar 2, 2023
- #1154

Turns out, we had never exposed an affordance for setting the Space
entrance! Whoopsie-doodle!

Co-authored-by: Dalton Pruitt <daltonrpruitt@users.noreply.github.com>
Co-authored-by: Kelly Hong <KellyAH@users.noreply.github.com>
zspencer added a commit that referenced this issue Mar 2, 2023
- #1154

Turns out, we had never exposed an affordance for setting the Space
entrance! Whoopsie-doodle!

Co-authored-by: Dalton Pruitt <daltonrpruitt@users.noreply.github.com>
Co-authored-by: Kelly Hong <KellyAH@users.noreply.github.com>

* `Refactor`: Use the whole word for `room`

Co-authored-by: KellyAH <KellyAH@users.noreply.github.com>

---------

Co-authored-by: Dalton Pruitt <daltonrpruitt@users.noreply.github.com>
Co-authored-by: Kelly Hong <KellyAH@users.noreply.github.com>
zspencer added a commit that referenced this issue Mar 2, 2023
- #1154
- #1161
- #1141

Deleting the `Client` was great! But when we merged the `Neighborhood`
first-run PR, we still had the `Client#name` field; which no longer
exists.

So now there's two tests for the `SpacesController#new` action:
- 1 to catch any errors in the happy-path request/response cycle
- 1 to make sure `Guest`s cant create a Space
zspencer added a commit that referenced this issue Mar 2, 2023
- #1154
- #1161
- #1141

Deleting the `Client` was great! But when we merged the `Neighborhood`
first-run PR, we still had the `Client#name` field; which no longer
exists.

So now there's two tests for the `SpacesController#new` action:
- 1 to catch any errors in the happy-path request/response cycle
- 1 to make sure `Guest`s cant create a Space
zspencer added a commit that referenced this issue Mar 3, 2023
- #1154
- #1161
- #1141

Deleting the `Client` was great! But when we merged the `Neighborhood`
first-run PR, we still had the `Client#name` field; which no longer
exists.

So now there's two tests for the `SpacesController#new` action:
- 1 to catch any errors in the happy-path request/response cycle
- 1 to make sure `Guest`s cant create a Space
zspencer added a commit that referenced this issue Mar 3, 2023
- #1154
- #1161
- #1141

Deleting the `Client` was great! But when we merged the `Neighborhood`
first-run PR, we still had the `Client#name` field; which no longer
exists.

So now there's two tests for the `SpacesController#new` action:
- 1 to catch any errors in the happy-path request/response cycle
- 1 to make sure `Guest`s cant create a Space
zspencer added a commit that referenced this issue Mar 3, 2023
- #1154
- #1161
- #1141

Deleting the `Client` was great! But when we merged the `Neighborhood`
first-run PR, we still had the `Client#name` field; which no longer
exists.

So now there's two tests for the `SpacesController#new` action:
- 1 to catch any errors in the happy-path request/response cycle
- 1 to make sure `Guest`s cant create a Space
zspencer added a commit that referenced this issue Mar 4, 2023
- #1154
- #1161
- #1141

Deleting the `Client` was great! But when we merged the `Neighborhood`
first-run PR, we still had the `Client#name` field; which no longer
exists.

So now there's two tests for the `SpacesController#new` action:
- 1 to catch any errors in the happy-path request/response cycle
- 1 to make sure `Guest`s cant create a Space
zspencer added a commit that referenced this issue Mar 31, 2023
- #832
- #1155
- #1154
- #709

As I was working to onboard Piikup, I discovered I couldn't really write
an easy script to merge into a space since I didn't have the
associations together.

Now they're super tight! Yyyaaaaaaah!
zspencer added a commit that referenced this issue Apr 2, 2023
- #832
- #1155
- #1154
- #709

As I was working to onboard Piikup, I discovered I couldn't really write
an easy script to merge into a space since I didn't have the
associations together.

Now they're super tight! Yyyaaaaaaah!
zspencer added a commit that referenced this issue Apr 14, 2023
- #1154

So, I don't really know what each Space's Terms of Service, Privacy
Policy, or Content Policy will be.

I would love for us to offer a set of different terms of service
tailored for different use-cases; but for now I think it's probably best
to put the responsibility on the Space Members to make sure they have
the appropriate agreements in place.

It's kind of a weird position to take, and not one I would advocate for
if we had a space ~$30k to invest in legal, but we don't and I'm not
sure if we have any capacity to do the work ourselves or find someone
who can do it pro-bono.

So we have a very tiny `Agreement` Model which `Space`s can have many
of, and maybe I'll even get to adding a `controller` with a `#show`
action and finding a place in the UI to enumerate the
`space#agreements`.
zspencer added a commit that referenced this issue Apr 15, 2023
* `Space`s: have `Agreement`s for "Terms of Service" etc.

- #1154

So, I don't really know what each Space's Terms of Service, Privacy
Policy, or Content Policy will be.

I would love for us to offer a set of different terms of service
tailored for different use-cases; but for now I think it's probably best
to put the responsibility on the Space Members to make sure they have
the appropriate agreements in place.

It's kind of a weird position to take, and not one I would advocate for
if we had a space ~$30k to invest in legal, but we don't and I'm not
sure if we have any capacity to do the work ourselves or find someone
who can do it pro-bono.

So we have a very tiny `Agreement` Model which `Space`s can have many
of, and maybe I'll even get to adding a `controller` with a `#show`
action and finding a place in the UI to enumerate the
`space#agreements`.

* 🥗 `Marketplace`: Test `Space::Agreement.friendly`

We use [`friendly_id`](https://github.com/norman/friendly_id) for
slug-ification atm, and this makes sure it's wired in right!
@zspencer zspencer mentioned this issue May 6, 2023
5 tasks
@zspencer zspencer mentioned this issue May 18, 2023
4 tasks
@zspencer zspencer changed the title 🥔Spaces 🥔✨ Spaces Jun 28, 2023
@zspencer zspencer changed the title 🥔✨ Spaces 🥔⛰️ Spaces Jun 28, 2023
zspencer added a commit that referenced this issue Oct 5, 2023
- #1154

Convene's branding isn't what's important, our client and community
owners are!
@zspencer zspencer changed the title 🥔⛰️ Spaces 🥔⛰️ Space Dec 19, 2023
@zspencer zspencer mentioned this issue May 2, 2024
3 tasks
@rosschapman
Copy link
Contributor

🧹 Relegated to cold storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛰️ epic Work we expect will take multiple patches to complete
Projects
None yet
Development

No branches or pull requests

2 participants