Client: Seems unnecessary and is getting in the way of things
#1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point, we may need to group `Space`s within `Client`, but today is not that day. Co-authored-by: Dalton Pruitt <daltonrpruitt@users.noreply.github.com> Co-authored-by: Kelly Hong <KellyAH@users.noreply.github.com>
zspencer
added a commit
that referenced
this pull request
Mar 2, 2023
- #1154 - #1161 - #1141 Deleting the `Client` was great! But when we merged the `Neighborhood` first-run PR, we still had the `Client#name` field; which no longer exists. So now there's two tests for the `SpacesController#new` action: - 1 to catch any errors in the happy-path request/response cycle - 1 to make sure `Guest`s cant create a Space
zspencer
added a commit
that referenced
this pull request
Mar 2, 2023
- #1154 - #1161 - #1141 Deleting the `Client` was great! But when we merged the `Neighborhood` first-run PR, we still had the `Client#name` field; which no longer exists. So now there's two tests for the `SpacesController#new` action: - 1 to catch any errors in the happy-path request/response cycle - 1 to make sure `Guest`s cant create a Space
zspencer
added a commit
that referenced
this pull request
Mar 3, 2023
- #1154 - #1161 - #1141 Deleting the `Client` was great! But when we merged the `Neighborhood` first-run PR, we still had the `Client#name` field; which no longer exists. So now there's two tests for the `SpacesController#new` action: - 1 to catch any errors in the happy-path request/response cycle - 1 to make sure `Guest`s cant create a Space
zspencer
added a commit
that referenced
this pull request
Mar 3, 2023
- #1154 - #1161 - #1141 Deleting the `Client` was great! But when we merged the `Neighborhood` first-run PR, we still had the `Client#name` field; which no longer exists. So now there's two tests for the `SpacesController#new` action: - 1 to catch any errors in the happy-path request/response cycle - 1 to make sure `Guest`s cant create a Space
zspencer
added a commit
that referenced
this pull request
Mar 3, 2023
- #1154 - #1161 - #1141 Deleting the `Client` was great! But when we merged the `Neighborhood` first-run PR, we still had the `Client#name` field; which no longer exists. So now there's two tests for the `SpacesController#new` action: - 1 to catch any errors in the happy-path request/response cycle - 1 to make sure `Guest`s cant create a Space
zspencer
added a commit
that referenced
this pull request
Mar 4, 2023
- #1154 - #1161 - #1141 Deleting the `Client` was great! But when we merged the `Neighborhood` first-run PR, we still had the `Client#name` field; which no longer exists. So now there's two tests for the `SpacesController#new` action: - 1 to catch any errors in the happy-path request/response cycle - 1 to make sure `Guest`s cant create a Space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point, we may need to group
Spaces withinClient, but today is not that day.