Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces: Customization #23

Closed
10 of 16 tasks
zspencer opened this issue May 29, 2020 · 15 comments
Closed
10 of 16 tasks

Spaces: Customization #23

zspencer opened this issue May 29, 2020 · 15 comments
Labels
⛰️ epic Work we expect will take multiple patches to complete ✨ feature Reduces Client's Burden or Grants them Benefits

Comments

@zspencer
Copy link
Member

zspencer commented May 29, 2020

Feature: Branded Spaces
  In order to have a place that is truly mine
  As a Space Owner
  I want to be able to brand my space with communicative and cosmetic details

TODO

  • Design
    • Write User Journey for Branded Spaces
    • Mockups for where to Configure Branded Spaces
  • Space Names
    • Space Owner may set their Space Name
  • 🥔✨ Space: Domains #74
  • Themes

Done

@zspencer zspencer added code ✨ feature Reduces Client's Burden or Grants them Benefits labels May 29, 2020
@zspencer zspencer added this to the 0.1.0 - Alpha milestone May 29, 2020
@maximegalon5
Copy link
Contributor

I've created a G Slide where I've pointed to some considerations.

They revolve around:

  • replacing with the Convene Logo <- which means we have to decide and pick something

  • Consider changing the "meet.zinc.coop" URL if we believe the branding is inconsistent with Convene (would love to know what @colombene @cricketlova think about this).

  • Consider changing the text on the landing page. I've made suggested changes in the Notes section of the slides, but defer to @colombene for a final go ahead.

@cricketlova
Copy link

@maximegalon5 - I am very pro- removing jitsi branding in place of Convene's. The two experiences feel completely different right now and have no reason for a customer to believe that they're the same.

Additional thoughts:

@cricketlova
Copy link

& out of the two logos, definitely prefer 'C' one over the weird one. Is there a vector file for the 'c' logo? I'd love to dabble around with them a bit (no promises that it will be any better)

@maximegalon5
Copy link
Contributor

@cricketlova we didn't but I used Inkscape to create one here. Let me know if that works or if there is any other ones you need me to convert.

The C one seems to be preferred by us all atm.

@zspencer zspencer changed the title Remove Jitsi branding Replace Jitsi branding with Convene Branding Jun 12, 2020
@user512 user512 self-assigned this Jun 20, 2020
@zspencer
Copy link
Member Author

zspencer commented Jun 20, 2020

@cricketlova and @maximegalon5 - I've created a set of checkboxes for each of the items to take care of while rebranding. We are choosing not to change the meet.zinc.coop landing page at this time; because we expect that to be a place where we'll want to do more heavy construction before we release Andromeda.

@cricketlova - Could you give me more specifics on what in the "in room" experience you think we should replace with which colors? Ideally with hex-codes?

zspencer pushed a commit that referenced this issue Jun 20, 2020
See: #23
* Also remove post-install because it's not being used
@user512 user512 changed the title Replace Jitsi branding with Convene Branding Apply Convene branding for branding awareness Jul 3, 2020
@user512 user512 changed the title Apply Convene branding for branding awareness Apply Convene branding for branding awareness and potential client not confused by Jitsi branding Jul 3, 2020
@zspencer zspencer changed the title Apply Convene branding for branding awareness and potential client not confused by Jitsi branding Guests see Convene Branding in Video Workspaces Jul 7, 2020
@zspencer zspencer changed the title Guests see Convene Branding in Video Workspaces Attendees see Convene Branding in Video Workspaces Jul 7, 2020
@user512
Copy link
Contributor

user512 commented Aug 12, 2020

Moving this back to in-progress because we haven't rebrand Jitsi Meet needs to use your microphone and camera.

My understanding is we simply need to passed interfaceConfig.APP_NAME to override this but we have already done that and it doesn't wokr.
Below is the source code referencing the user media permission overlay.
https://github.com/jitsi/jitsi-meet/blob/8e9a51f74297f26d569283f02afb6fc2674677ff/react/features/overlay/components/web/UserMediaPermissionsOverlay.js#L36
https://github.com/jitsi/jitsi-meet/blob/8e9a51f74297f26d569283f02afb6fc2674677ff/lang/main.json#L661

@user512
Copy link
Contributor

user512 commented Aug 12, 2020

Found this, looks like the Jitsi team disabled that, so we will have to edit the js code in Jitsi Meet to achieve that.

If you use your own deployment please edit interface_config.js instead of using overrides, since we disabled some, due to people not respecting our fair use instructions.

https://community.jitsi.org/t/app-name-doesnt-have-effect/71648/2

@zspencer zspencer changed the title Attendees see Convene Branding in Video Workspaces People see Convene Branding in Video Workspaces Aug 20, 2020
@maximegalon5
Copy link
Contributor

maximegalon5 commented Aug 24, 2020

@maximegalon5 - In your usage over the past week have you seen JITSI branding anywhere?

No, I have not. Went to the demo site and fiddled around with it and don't see Jitsi anywhere, currently <- on my regular Chrome browser. However, I checked with a browser that I don't use and saw a reference. Uploading the screenshot on Slack.

@maximegalon5
Copy link
Contributor

maximegalon5 commented Aug 24, 2020

Annotation 2020-08-24 113752

Also here. Didn't see it anywhere else on my desktop.

@user512
Copy link
Contributor

user512 commented Aug 24, 2020

Still showing Jitsi Meet, I can take a look again.

@user512 user512 self-assigned this Aug 24, 2020
@user512 user512 removed their assignment Aug 25, 2020
@user512
Copy link
Contributor

user512 commented Aug 25, 2020

Provisioned a new video bridge instance with a new snapshot that has the brand name changes.
Ready to be confirmed.

@zspencer
Copy link
Member Author

Thank you! This looks like it's working! I must have screwed up something when I allocated an instance...

@user512
Copy link
Contributor

user512 commented Aug 25, 2020

Likely because I delete the wrong snapshot after testing #84.

@zspencer zspencer added ⛰️ epic Work we expect will take multiple patches to complete and removed code labels Sep 11, 2020
@zspencer zspencer changed the title People do not see Jitsi Branding in Convene Spaces Branded Spaces Nov 29, 2020
@zspencer
Copy link
Member Author

I'm expanding this issue to include more things around expression of color, as well as the domain-level customization

@zspencer zspencer reopened this Nov 29, 2020
@zspencer zspencer added the test label Jan 10, 2021
@zspencer zspencer changed the title Branded Spaces Feature: Branded Spaces May 24, 2021
@zspencer zspencer removed this from the 1.0 - Andromeda milestone Sep 18, 2022
@zspencer zspencer removed the test label Oct 21, 2022
@zspencer zspencer changed the title Feature: Branded Spaces Spaces: Customization Dec 21, 2022
zspencer added a commit that referenced this issue Dec 21, 2022
#23
#74

Apparently `domain` doesn't uhh... quite work. `host` does!
zspencer added a commit that referenced this issue Dec 22, 2022
#23
#74

When I was testing #74 on https://beta.zeespencer.com/ I discovered that it didn't quite work, and was nesting sub-domains (i.e. `beta.zeespencer.com` became `beta.beta.zeespencer.com`)

This is likely because the [`domain` option for `url_for`](http://api.rubyonrails.org/classes/ActionDispatch/Routing/UrlFor.html#method-i-url_for) doesn't actually do the whole domain; just the TLD!

Womp womp!
@zspencer zspencer closed this as completed Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛰️ epic Work we expect will take multiple patches to complete ✨ feature Reduces Client's Burden or Grants them Benefits
Projects
None yet
Development

No branches or pull requests

4 participants