Replace Jitsi Meet branding to Convene #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user512
force-pushed
the
remove-jitsi-meet-branding
branch
from
11a9c91
to
9cf5b6b
Compare
While Jisti iframe Api interfaceConfigOverride mentioned APP_NAME, APP_NAME doesn't have effect. Jitsi team disabled APP_NAME due to users not respecting fair use instructions. Convene is deploying its own instance of Jitsi so it's fair for us to replace with Convene branding. Ref: https://community.jitsi.org/t/app-name-doesnt-have-effect/71648/2 We might be able to dig into jitsi-meet React codebase to re-enable APP_NAME but that would require us to build jitsi-meet frontend code upon deploy instead of getting packages via apt-get. If we ever have feature request for dynamic branding of Convene/ Jitsi, we could look into that in the future.
user512
force-pushed
the
remove-jitsi-meet-branding
branch
from
9cf5b6b
to
5aaa284
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #23
While Jisti iframe Api
interfaceConfigOverridementioned APP_NAME,APP_NAME doesn't have effect.
Jitsi team disabled APP_NAME due to users not respecting fair use instructions.
Convene is deploying its own instance of Jitsi so it's fair for us to
replace with Convene branding.
Ref: https://community.jitsi.org/t/app-name-doesnt-have-effect/71648/2
We might be able to dig into jitsi-meet React codebase to re-enable APP_NAME
but that would require us to build jitsi-meet frontend code upon deploy instead of
getting packages via apt-get.
If we ever have feature request for dynamic branding of Convene/ Jitsi, we could look into
that in the future.
If we want to have dynamic branding, I think we just need to edit this file and built our own jitsi-meet front end code, however I haven't test this approach.
Tested by ssh into convene-videobridge-zinc.zinc.coop
