Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine zn.deps and zn.nodes to zntrack.deps #719

Merged
merged 19 commits into from
Sep 22, 2023

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Sep 19, 2023

This uses the name key in the zntrack.json to identify a zn.nodes as follows

"instance": {
  "_type": "zntrack.Node",
  "value": {
    "module": "ipsuite.nodes",
    "cls": "SmilesToAtoms",
    "name": "parent:attr:<idx|key>",
    "remote": null,
     "rev": null
  }
},
  • remove logging statements
  • fix all tests
  • tests for 3f7d00f !
  • use from typing_extensions import deprecated for the zn and dvc modules (Deprecate zntrack.zn.<field> and zntrack.dvc.<field> #722)
  • check that it works with groups (group names are currently applied after the name of the zn.nodes is set)
  • check that it works with _name_ = "CustomNodeName"
  • zn.nodes with node.attr tests

@PythonFZ PythonFZ linked an issue Sep 19, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #719 (55ee11c) into main (a6fcabf) will decrease coverage by 3.98%.
The diff coverage is 76.95%.

❗ Current head 55ee11c differs from pull request most recent head 6b4fa95. Consider uploading reports for the commit 6b4fa95 to get more accurate results

@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
- Coverage   89.86%   85.89%   -3.98%     
==========================================
  Files          22       25       +3     
  Lines        1717     1893     +176     
  Branches      698      789      +91     
==========================================
+ Hits         1543     1626      +83     
- Misses        174      267      +93     
Flag Coverage Δ
fulltest 85.89% <76.95%> (-3.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
zntrack/fields/zn/options.py 60.14% <60.14%> (ø)
zntrack/fields/dvc/__init__.py 87.09% <81.81%> (-1.80%) ⬇️
zntrack/core/load.py 97.26% <92.59%> (-2.74%) ⬇️
zntrack/fields/dvc/options.py 93.33% <93.33%> (ø)
zntrack/fields/zn/__init__.py 95.23% <95.23%> (+3.36%) ⬆️
zntrack/fields/dependency.py 95.31% <95.31%> (ø)
zntrack/core/node.py 93.83% <100.00%> (+0.08%) ⬆️
zntrack/fields/fields.py 100.00% <100.00%> (+18.18%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PythonFZ PythonFZ marked this pull request as ready for review September 21, 2023 20:58
@PythonFZ PythonFZ merged commit 33cd32b into main Sep 22, 2023
8 checks passed
@PythonFZ PythonFZ deleted the 583-combine-zndeps-and-znnodes branch September 22, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine zn.deps and zn.nodes
1 participant