Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate zntrack.zn.<field> and zntrack.dvc.<field> #722

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

PythonFZ
Copy link
Member

No description provided.

@PythonFZ PythonFZ changed the title Deprecated zntrack.zn.<field> and zntrack.dvc.<field> Deprecate zntrack.zn.<field> and zntrack.dvc.<field> Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #722 (ed4b996) into 583-combine-zndeps-and-znnodes (27a86ed) will decrease coverage by 0.62%.
The diff coverage is 69.47%.

@@                        Coverage Diff                         @@
##           583-combine-zndeps-and-znnodes     #722      +/-   ##
==================================================================
- Coverage                           84.21%   83.59%   -0.62%     
==================================================================
  Files                                  23       25       +2     
  Lines                                1957     1981      +24     
  Branches                              835      835              
==================================================================
+ Hits                                 1648     1656       +8     
- Misses                                309      325      +16     
Flag Coverage Δ
fulltest 83.59% <69.47%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
zntrack/fields/zn/options.py 60.14% <60.14%> (ø)
zntrack/fields/dvc/__init__.py 87.09% <81.81%> (-1.80%) ⬇️
zntrack/fields/dvc/options.py 93.33% <93.33%> (ø)
zntrack/fields/zn/__init__.py 95.23% <95.23%> (+26.68%) ⬆️
zntrack/core/node.py 93.83% <100.00%> (+0.02%) ⬆️
zntrack/fields/dependency.py 70.37% <100.00%> (+0.46%) ⬆️
zntrack/fields/fields.py 100.00% <100.00%> (+13.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PythonFZ PythonFZ merged commit a794980 into 583-combine-zndeps-and-znnodes Sep 21, 2023
5 of 8 checks passed
@PythonFZ PythonFZ deleted the deprecated_zn_dvc branch September 21, 2023 17:41
PythonFZ added a commit that referenced this pull request Sep 22, 2023
* add tests

* working zn.deps port, not working zn.nodes

* first draft of a combined `zn.nodes` and `zn.deps` class

* bugfix

* bugfix

* bugfix (requires tests)

* bugfix

* more tests

* update all `zn.deps` and `zn.nodes` to `zntrack.deps`

* intermediate results

* it works!

* update zninit + bugfix

* Deprecate `zntrack.zn.<field>` and `zntrack.dvc.<field>` (#722)

* deprecated zntrack.zn and zntrack.dvc

* deprecate 'zntrack.zn' and 'zntrack.dvc' modules

* bump zntrack version to 0.7.0

* update imports

* remove print statements

* fix tests; use deepcopy

* code style

* preparation for new tests

* bugfix?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant