Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zebra primitives #82

Merged
merged 8 commits into from
Oct 31, 2024
Merged

Zebra primitives #82

merged 8 commits into from
Oct 31, 2024

Conversation

idky137
Copy link
Contributor

@idky137 idky137 commented Oct 23, 2024

This PR removed the primitives mod from zaino-fetch, using zebra's structs directly possible and adding wrapper structs in zaino-fetch::jsonrpc::response.rs where required.

*NOTE: There are currently several patched libraries in Zebra v2.0.0rc that are causing conflicts. For this reason we are currently using v1.9.0 and will update to 2.0.0 once these patches are removed.

@idky137 idky137 added the ZGM1 Issues that need to be resolved for the completion of the Zaino dev grant milestone 1 label Oct 23, 2024
@idky137 idky137 marked this pull request as ready for review October 23, 2024 18:40
This was referenced Oct 28, 2024
@idky137 idky137 added the PriorityHigh Current objectives and issues label Oct 28, 2024
Copy link
Contributor

@Oscar-Pepper Oscar-Pepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left non-blocking comments

@Oscar-Pepper Oscar-Pepper merged commit 8eb9f73 into zingolabs:dev Oct 31, 2024
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PriorityHigh Current objectives and issues ZGM1 Issues that need to be resolved for the completion of the Zaino dev grant milestone 1
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants