-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zebra primitives #82
Merged
Merged
Zebra primitives #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
This was referenced Oct 28, 2024
Merged
Oscar-Pepper
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left non-blocking comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PriorityHigh
Current objectives and issues
ZGM1
Issues that need to be resolved for the completion of the Zaino dev grant milestone 1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removed the primitives mod from zaino-fetch, using zebra's structs directly possible and adding wrapper structs in zaino-fetch::jsonrpc::response.rs where required.
*NOTE: There are currently several patched libraries in Zebra v2.0.0rc that are causing conflicts. For this reason we are currently using v1.9.0 and will update to 2.0.0 once these patches are removed.