Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dependency and interface for bytes #1515

Merged
merged 1 commit into from
Nov 15, 2024
Merged

update dependency and interface for bytes #1515

merged 1 commit into from
Nov 15, 2024

Conversation

zancas
Copy link
Member

@zancas zancas commented Nov 14, 2024 •
edited
Loading

Running sanity tests locally. This PR is open now for CI parallelization.

@zancas
Copy link
Member Author

zancas commented Nov 14, 2024

This seems merge ready to me based on this sanity test result:

        PASS [ 335.898s] libtonode-tests::concrete slow::witness_clearing
------------
     Summary [1147.899s] 332 tests run: 332 passed (109 slow), 31 skipped
1731623057 || shofth nattyb bump_bytes[ ]
REDACTED/bump_bytes: 0 $
git show -s
commit a6b24a2b443173a6e62b63538ca9bfa638e9b258 (HEAD -> bump_bytes, zancos/bump_bytes)
Author: zancas <zancas@zingolabs.org>
Date:   Thu Nov 14 15:00:56 2024 -0700

    update dependency and interface for bytes
1731623063 || shofth nattyb bump_bytes[ ]

@zancas zancas mentioned this pull request Nov 14, 2024
Closed
@zancas
Copy link
Member Author

zancas commented Nov 14, 2024

Obsoletes #1173

@zancas zancas requested a review from dorianvp November 14, 2024 22:26
@zancas zancas mentioned this pull request Nov 14, 2024
Merged
@dorianvp dorianvp merged commit 4abac5c into zingolabs:dev Nov 15, 2024
17 checks passed
@zancas zancas deleted the bump_bytes branch November 30, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorianvp dorianvp dorianvp approved these changes

@AloeareV AloeareV Awaiting requested review from AloeareV

@Oscar-Pepper Oscar-Pepper Awaiting requested review from Oscar-Pepper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zancas @dorianvp