Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pemfile #1516

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Bump pemfile #1516

merged 2 commits into from
Nov 15, 2024

Conversation

zancas
Copy link
Member

@zancas zancas commented Nov 14, 2024

Obsoletes #1259 and builds on #1515 .

Opening now to parallelize CI with sanity testing.

@zancas
Copy link
Member Author

zancas commented Nov 14, 2024

Based on these sanity test results I think this is merge ready:

        PASS [ 341.944s] libtonode-tests::concrete slow::witness_clearing
------------
     Summary [1157.508s] 332 tests run: 332 passed (109 slow), 31 skipped
1731625837 || shofth nattyb bump_bytes[ ]
REDACTED/bump_bytes: 0 $
git show -s
commit 13ceef9a5b366fe9460e18a6aa3809ae0d19fb7c (HEAD -> bump_bytes, zancos/bump_pemfile)
Author: zancas <zancas@zingolabs.org>
Date:   Thu Nov 14 15:46:58 2024 -0700

    update the rustls-pemfile version, AND move it to a dev-dependency in netutils

dorianvp
dorianvp previously approved these changes Nov 15, 2024
@zancas zancas dismissed dorianvp’s stale review November 15, 2024 00:44

The merge-base changed after approval.

Copy link
Member

@dorianvp dorianvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing

@dorianvp dorianvp merged commit 45e39fb into zingolabs:dev Nov 15, 2024
17 checks passed
@zancas zancas deleted the bump_pemfile branch November 30, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants