chore: clean up circuits #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Divide-By-0
reviewed
Sep 19, 2023
|
Sweet! Can you add some quick tests for the main helpers? |
javiersuweijie
force-pushed
the
chore/clean-up-circuits
branch
from
bd1a258
to
23350b0
Compare
|
Circom looks like it's failing CI? Forge tests make sense since our alchemy key is not run for external prs. |
javiersuweijie
force-pushed
the
chore/clean-up-circuits
branch
from
e1f366c
to
679d4df
Compare
javiersuweijie
force-pushed
the
chore/clean-up-circuits
branch
from
679d4df
to
795866a
Compare
Set max workers for on CI to 2 so that it doesn't go OOM when running too many tests in parallel |
Divide-By-0
reviewed
Sep 25, 2023
| "21888242871839275222246405745257275088548364400416034343698204186575808495617" | ||
| ); | ||
|
|
||
| describe("SHA256 for email header", () => { |
There was a problem hiding this comment.
This isn't really an email header test right...
Divide-By-0
reviewed
Sep 25, 2023
| // Compile: circom "./tests/email-verifier-test.circom" --r1cs --wasm --sym --c --wat --output "./tests/compiled-test-circuit" | ||
| recompile: true, | ||
| output: path.join(__dirname, "./compiled-test-circuit"), | ||
| include: path.join(__dirname, "../../../node_modules"), |
There was a problem hiding this comment.
Csv we make this non relative at all or nah
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.