Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/improvements in helpers #189

Merged
merged 19 commits into from
Apr 6, 2024
Merged

Refactor/improvements in helpers #189

merged 19 commits into from
Apr 6, 2024

Conversation

saleel
Copy link
Member

@saleel saleel commented Apr 3, 2024

Description

  • Fix multiple DKIM edge cases
  • Add option to generate inputs from raw eml
  • Add tests for DKIM sanitizations, input helpers
  • Rename files and functions to keep be uniform
  • Remove unused code

Note: This is based to feat/circuit-refactor which is based to v4. Major version v4 can be released after both PRs are merged and docs are updated.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have discussed with the team prior to submitting this PR
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Copy link

socket-security bot commented Apr 3, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@types/lodash@4.14.195

View full report↗︎

Base automatically changed from feat/circuit-refactor to v4 April 6, 2024 05:20
@saleel saleel merged commit 4aa2afa into v4 Apr 6, 2024
5 checks passed
@saleel saleel deleted the feat/helpers-improvements branch April 19, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant