Fix regression in Syntax04 #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change introduced in zonemaster#1322 to make Syntax04 take the domain under test, instead of a name server name, had a little oversight that caused the zone under test being tested for good syntax, instead of a name server name. Make sure we refer to the correct variable.
marc-vanderwal
added
T-Bug
marc-vanderwal
requested review from
mattias-p,
matsduf,
tgreenx and
MichaelTimbert
tgreenx
approved these changes
Jul 1, 2024
mattias-p
approved these changes
Jul 1, 2024
|
@marc-vanderwal, please merge. |
Merging… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes a small regression caused by code refactoring.
Context
See #1368 (and the original changes that introduced the regression being addressed by this PR: #1322).
Changes
How to test this PR
Run the following two tests.
Firstly, run the following command:
Expect one of the lines in the output to have a
NAMESERVER_NON_ALLOWED_CHARSmessage like so:Secondly, run a complete test on
hipotel.fr, either usingzonemaster-cli hipotel.fror from GUI. Expect an error message stating “Found illegal characters in the nameserver (100\0321\032443\032sipdir.online.lync.com).”.