Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: HTTPS without nginx #976

Closed
2 tasks done
andy-shi88 opened this issue Jul 27, 2020 · 0 comments
Closed
2 tasks done

Bug: HTTPS without nginx #976

andy-shi88 opened this issue Jul 27, 2020 · 0 comments
Labels
BUG Something isn't working
Milestone
Milestone 19

Comments

@andy-shi88
Copy link
Contributor

Description

https is not working after merging the proxy with rpc handler. This is because we are binding the tls to the grpcserver instead of the httpServer (wrapper).

Breakdowns:

  • bind tls cert to httpServer
  • handle cors of grpcweb
@andy-shi88 andy-shi88 added the BUG Something isn't working label Jul 27, 2020
@andy-shi88 andy-shi88 added this to the Milestone 19 milestone Jul 27, 2020
@andy-shi88 andy-shi88 self-assigned this Jul 27, 2020
@andy-shi88 andy-shi88 mentioned this issue Jul 27, 2020
Merged
2 tasks
iltoga pushed a commit that referenced this issue Jul 27, 2020
@andy-shi88
#976 bind https cert to httpServer (#977)
822b6d3
@andy-shi88 andy-shi88 removed their assignment Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BUG Something isn't working
Projects
None yet
Milestone
Milestone 19
Development

No branches or pull requests
1 participant
@andy-shi88