#976 bind https cert to httpServer #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iltoga
approved these changes
Jul 27, 2020
astaphobia
reviewed
Jul 27, 2020
| wrappedServer := grpcweb.WrapServer(grpcServer) | ||
| wrappedServer := grpcweb.WrapServer( | ||
| grpcServer, | ||
| grpcweb.WithCorsForRegisteredEndpointsOnly(true), |
There was a problem hiding this comment.
So this grpcwebproxy allow to switch to disable ?
There was a problem hiding this comment.
no disable yet
but this merge the proxy port to normal rpc port
before we have :7000 for rpc and :8002 for proxy
now we only need :7000 to handle both 👍
sukrawidhyawan
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix services https.
Breakdown
Reference Issue
Close #976