Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused annotation prop from task inputs #5104

Merged
merged 2 commits into from
Nov 29, 2018
Merged

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Nov 28, 2018

Staging branch URL: https://pr-5104.pfe-preview.zooniverse.org

#5091 removed the annotation prop from TaskInputField but I forgot to remove it from the instances of the component itself. This removes that prop from the input field in multiple choice, single answer and drawing tasks. It also tidies up the drawing task render method to make the tool choices easier to understand.

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you rm -rf node_modules/ && npm install and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on Travis?

Optional

Remove unused annotation prop from multiple choice and single answer tasks.
Remove unused annotation prop from task input field.
Clean up the code that renders the drawing tool choices to make it more readable.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 48.099% when pulling 4fd5233 on task-input-styles into 9895439 on master.

@eatyourgreens eatyourgreens changed the title Task input styles Remove unused annotation prop from task inputs Nov 28, 2018
@mcbouslog mcbouslog self-requested a review November 29, 2018 16:32
@mcbouslog mcbouslog self-assigned this Nov 29, 2018
Copy link
Contributor

@mcbouslog mcbouslog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcbouslog mcbouslog merged commit 056a4af into master Nov 29, 2018
@mcbouslog mcbouslog deleted the task-input-styles branch November 29, 2018 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants