Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update input styles #306

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Update input styles #306

merged 2 commits into from
Dec 4, 2018

Conversation

srallen
Copy link
Contributor

@srallen srallen commented Nov 27, 2018

Package: lib-classifier

Describe your changes:
Gets the inputs to parity again with inputs in PFE (zooniverse/Panoptes-Front-End#5091). Bumps React version in order to use React.memo and refactors some of the tests because enzyme doesn't support React.memo yet.

The refactors of the styling reduces the manual handling of focus and blur and consequently speeds up the styling.

Review Checklist

General

  • Are the tests passing locally and on Travis?
  • Is the documentation up to date?
  • Is the changelog updated?

Apps

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you rm -rf node_modules/ && npm install and app works as expected?

@srallen srallen added the enhancement New feature or request label Nov 27, 2018
@srallen srallen changed the title Bump react. Get styling to parity with PFE. Fix tests. Fix warnings Update input styles Nov 27, 2018
@srallen srallen mentioned this pull request Nov 27, 2018
6 tasks
@srallen
Copy link
Contributor Author

srallen commented Dec 4, 2018

This just mirrors zooniverse/Panoptes-Front-End#5091 which is already approved.

@srallen srallen merged commit c857a1d into master Dec 4, 2018
@srallen srallen deleted the styled-inputs branch December 4, 2018 20:01
@eatyourgreens
Copy link
Contributor

I forgot that I’d removed the annotation prop in that PR, so there was a small follow-up PR too. zooniverse/Panoptes-Front-End#5104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants