Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update panoptes-client (PJC) to 5.6.2 / fix #7111

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

shaunanoordin
Copy link
Member

@shaunanoordin shaunanoordin commented May 29, 2024

PR Overview

Staging branch URL: https://pr-7111.pfe-preview.zooniverse.org
Related: #7066

This PR bumps PJC to 5.6.2, which includes a fix to responses on Talk posts going nuts on occasion.

Turns out that, while PJC was correctly updated with the fix, PFE wasn't updated with the latest version of PJC.

Note: this is more targeted than #7109, and only intends to fix the Talk issue.

Testing

Compare: https://www.zooniverse.org/talk/search?page=3&query=depression

With: https://pr-7111.pfe-preview.zooniverse.org/talk/search?page=3&query=depression&env=production

The the second link should display all talk posts correctly.

Also, baseline tests: ensure you can login/logout, view the Projects page, view a random project, and submit a Classification.

Status

Ready for review. Reviewer, please merge & deploy if everything looks good.

@shaunanoordin shaunanoordin requested review from goplayoutside3 and a team May 29, 2024 00:06
@goplayoutside3 goplayoutside3 self-assigned this May 29, 2024
@coveralls
Copy link

Coverage Status

coverage: 56.98%. remained the same
when pulling ea38361 on bump-pjc-5.6.2
into d270c1a on master.

@shaunanoordin
Copy link
Member Author

Additional Investigation Notes

I'm assuming the reason that PJC 5.6.2 wasn't automagically installed into PFE despite package.json specifying "panoptes-client": "~5.6.0" was because npm install was never explicitly triggered during the past few months of PFE development (meaning package-lock.json was never updated), and all instead all builds & deploys were done with npm ci which would've used 5.6.0 which was specified in the package-lock.

That said, I'm still trying to understand why Dependabot didn't automatically create a bump PR for PJC, since it has already done so before (example) and continues to try to bump everything we don't want to.

@goplayoutside3 goplayoutside3 merged commit b8cf174 into master May 29, 2024
5 checks passed
@goplayoutside3 goplayoutside3 deleted the bump-pjc-5.6.2 branch May 29, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants