v5.6.2

[mcbouslog]

New patch version with:

• Bump github/codeql-action from 2 to 3
• Update README publishing instructions
• Fix to ignore null items in API responses

[shaunanoordin]

PR Review

This PR bumps PJC to v 5.6.2, which packages #229 (dependabot bump), #235 (readme update), and, most functionally relevant, #240 (fix null items bug)

Testing

I tried testing this locally by doing a supposedly straightforward setup where...

1. in my local panoptes-javascript-client folder, I'd pull this branch v5.6.2
2. in my local Panoptes-Front-End folder (which uses PJC), I'd update the package.json so it imports my local PJC: "panoptes-client": "file:../panoptes-javascript-client"
3. I'd run PFE, and make sure everything functions correctly

...but that didn't work out. There was some webpack issues resolving url.

So in the end, my less elegant setup was:

1. pull branch v5.6.2 into my local panoptes-javascript-client folder
2. copy the entire folder into my local PFE's modules, i.e. /panoptes-javascript-client ==> /Panoptes-Front-End/node_modules/panoptes-javascript-cient

Testing steps:

• View the Zooniverse home page local.zooniverse.org:3735
  • Attempt to sign in & sign out
• View the projects page
• Select a random project. Attempt to Classify
  • Confirm that subjects load for classifying, and attempt to submit classifications
• (confirming fix for 240): when viewing the Talk page with null results, confirm the page doesn't just fail with an error message.
  • i.e. compare: https://local.zooniverse.org:3735/talk/search?page=3&query=depression&env=production with https://www.zooniverse.org/talk/search?page=3&query=depression&env=production

Tests look good, though I need to find a more elegant method of testing PJC updates on local.

Status

LGTM! 👍

[mcbouslog]

Locally, I ran npm link in PJC then npm link panoptes-client in PFE. I think I got the same webpack error, and I think the solution was adding the forward slash to PFE's webpack.dev.js => url: require.resolve("url/"),. Then I got a few ENV errors, but in the same webpack.dev.js file changing to the following I think did the trick:

new webpack.EnvironmentPlugin({
      'HEAD_COMMIT': null,
      'NODE_ENV': 'development',
      'PANOPTES_API_APPLICATION': null,
      'PANOPTES_API_HOST': null,
      'STAT_HOST': null,
      'SUGAR_HOST': null,
      'TALK_HOST': null,
      'ERAS_HOST': null, // <--- this and the following are the new lines/changes
      'OAUTH_HOST': null,
      'REACT_APP_ENV': null,
    }),

I'm not sure if I should make these changes in PFE, note them somewhere in this library (README, local testing notes?), or otherwise.