Edit language list, remove dialect specificity #848
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,103 +1,99 @@ | ||
| const languages = [ | ||
| { value: 'af', label: 'Afrikaans' }, | ||
| { value: 'sq', label: 'Albanian' }, | ||
| { value: 'gsw', label: 'Alsatian' }, | ||
| { value: 'am', label: 'Amharic' }, | ||
| { value: 'ar', label: 'Arabic' }, | ||
| { value: 'hy', label: 'Armenian' }, | ||
| { value: 'as', label: 'Assamese' }, | ||
| { value: 'az', label: 'Azeri' }, | ||
| { value: 'ba', label: 'Bashkir' }, | ||
| { value: 'eu', label: 'Basque' }, | ||
| { value: 'be', label: 'Belarusian' }, | ||
| { value: 'bn', label: 'Bengali' }, | ||
| { value: 'bs', label: 'Bosnian' }, | ||
| { value: 'bs-cyrl-ba', label: 'Bosnian (Cyrillic, Bosnia and Herzegovina)' }, | ||
| { value: 'bs-latn-ba', label: 'Bosnian (Latin, Bosnia and Herzegovina)' }, | ||
| { value: 'br', label: 'Breton' }, | ||
| { value: 'bg', label: 'Bulgarian' }, | ||
| { value: 'ca', label: 'Catalan' }, | ||
| { value: 'zh-cn', label: 'Chinese (Simplified)' }, | ||
| { value: 'zh-tw', label: 'Chinese (Traditional)' }, | ||
| { value: 'hr', label: 'Croatian' }, | ||
| { value: 'cs', label: 'Czech' }, | ||
| { value: 'da', label: 'Danish' }, | ||
| { value: 'prs', label: 'Dari' }, | ||
| { value: 'div', label: 'Divehi' }, | ||
| { value: 'nl', label: 'Dutch' }, | ||
| { value: 'en', label: 'English' }, | ||
| { value: 'et', label: 'Estonian' }, | ||
| { value: 'fo', label: 'Faroese' }, | ||
| { value: 'fil', label: 'Filipino' }, | ||
| { value: 'fi', label: 'Finnish' }, | ||
| { value: 'fr', label: 'French' }, | ||
| { value: 'gl', label: 'Galician' }, | ||
| { value: 'ka', label: 'Georgian' }, | ||
| { value: 'de', label: 'German' }, | ||
| { value: 'el', label: 'Greek' }, | ||
| { value: 'kl', label: 'Greenlandic' }, | ||
| { value: 'gu', label: 'Gujarati' }, | ||
| { value: 'ha', label: 'Hausa' }, | ||
| { value: 'he', label: 'Hebrew' }, | ||
| { value: 'hi', label: 'Hindi' }, | ||
| { value: 'hu', label: 'Hungarian' }, | ||
| { value: 'is', label: 'Icelandic' }, | ||
| { value: 'ig', label: 'Igbo' }, | ||
| { value: 'id', label: 'Indonesian' }, | ||
| { value: 'iu', label: 'Inuktitut' }, | ||
| { value: 'iu-latn-ca', label: 'Inuktitut (Latin, Canada)' }, | ||
| { value: 'iu-cans-ca', label: 'Inuktitut (Syllabics, Canada)' }, | ||
| { value: 'ga', label: 'Irish' }, | ||
| { value: 'xh', label: 'isiXhosa' }, | ||
| { value: 'zu', label: 'isiZulu' }, | ||
| { value: 'it', label: 'Italian' }, | ||
| { value: 'ja', label: 'Japanese' }, | ||
| { value: 'kn', label: 'Kannada' }, | ||
| { value: 'kk', label: 'Kazakh' }, | ||
| { value: 'km', label: 'Khmer' }, | ||
| { value: 'qut', label: 'K\'iche' }, | ||
| { value: 'rw', label: 'Kinyarwanda' }, | ||
| { value: 'sw', label: 'Kiswahili' }, | ||
| { value: 'kok', label: 'Konkani' }, | ||
| { value: 'ko', label: 'Korean' }, | ||
| { value: 'ky', label: 'Kyrgyz' }, | ||
| { value: 'lo', label: 'Lao' }, | ||
| { value: 'lv', label: 'Latvian' }, | ||
| { value: 'lt', label: 'Lithuanian' }, | ||
| { value: 'wee', label: 'Lower Sorbian' }, | ||
| { value: 'lb', label: 'Luxembourgish' }, | ||
| { value: 'mk', label: 'Macedonian' }, | ||
| { value: 'ms', label: 'Malay' }, | ||
| { value: 'ml', label: 'Malayalam' }, | ||
| { value: 'mt', label: 'Maltese' }, | ||
| { value: 'mi', label: 'Maori' }, | ||
| { value: 'arn', label: 'Mapudungun' }, | ||
| { value: 'mr', label: 'Marathi' }, | ||
| { value: 'moh', label: 'Mohawk' }, | ||
| { value: 'mn', label: 'Mongolian' }, | ||
| { value: 'ne', label: 'Nepali' }, | ||
| { value: 'no', label: 'Norwegian' }, | ||
| { value: 'oc', label: 'Occitan' }, | ||
| { value: 'or', label: 'Oriya' }, | ||
| { value: 'ps', label: 'Pashto' }, | ||
| { value: 'fa', label: 'Persian' }, | ||
| { value: 'pl', label: 'Polish' }, | ||
| { value: 'pt', label: 'Portuguese' }, | ||
| { value: 'pa', label: 'Punjabi' }, | ||
| { value: 'qu', label: 'Quechua' }, | ||
| { value: 'ro', label: 'Romanian' }, | ||
| { value: 'rm', label: 'Romansh' }, | ||
| { value: 'ru', label: 'Russian' }, | ||
| { value: 'sa', label: 'Sanskrit' }, | ||
| { value: 'sr', label: 'Serbian' }, | ||
| { value: 'st', label: 'Sesotho' }, | ||
| { value: 'nso', label: 'Sesotho sa Leboa' }, | ||
| { value: 'tn', label: 'Setswana' }, | ||
| { value: 'si', label: 'Sinhala' }, | ||
| { value: 'sk', label: 'Slovak' }, | ||
| { value: 'sl', label: 'Slovenian' }, | ||
| { value: 'es', label: 'Spanish' }, | ||
|
|
@@ -109,24 +105,24 @@ const languages = [ | |
| { value: 'tt', label: 'Tatar' }, | ||
| { value: 'te', label: 'Telugu' }, | ||
| { value: 'th', label: 'Thai' }, | ||
| { value: 'bo', label: 'Tibetan' }, | ||
| { value: 've', label: 'Tshivenḓa' }, | ||
| { value: 've', label: 'Venḓa' }, | ||
| { value: 'tr', label: 'Turkish' }, | ||
| { value: 'tk', label: 'Turkmen' }, | ||
| { value: 'ug', label: 'Uighur' }, | ||
| { value: 'uk', label: 'Ukrainian' }, | ||
| { value: 'wen', label: 'Upper Sorbian' }, | ||
| { value: 'ur', label: 'Urdu' }, | ||
| { value: 'uz', label: 'Uzbek' }, | ||
| { value: 'vi', label: 'Vietlabelse' }, | ||
| { value: 'cy', label: 'Welsh' }, | ||
| { value: 'wo', label: 'Wolof' }, | ||
| { value: 'ts', label: 'Xitsonga'}, | ||
| { value: 'ts', label: 'Tsonga'}, | ||
|
Comment on lines
121
to
122
There was a problem hiding this comment. Fascinating, there are two possible labels for the Tsonga language. Both are valid, though I'm noting that PFE (as of PR 7134) only uses the 'Xitsonga' label https://en.wikipedia.org/wiki/Tsonga_language No changes necessary on either this PR or the PF PR, but worth a follow up discussion. There was a problem hiding this comment. Duplicate entries allow for more flexible language name search. As implemented in #666, these multiple entries allow users to match via endonym and exonym language names. For additional related discussion, see: zooniverse/Panoptes-Front-End#6729 (comment), zooniverse/Panoptes-Front-End#6732 (comment) Note: this multiple label flexibility is a Pandora-only feature, so a single value/label combination must be chosen for the PFE language list. To choose single labels, we defer to the option used or preferred by local speakers. |
||
| { value: 'sah', label: 'Yakut' }, | ||
| { value: 'ii', label: 'Yi' }, | ||
| { value: 'yo', label: 'Yoruba' } | ||
| ]; | ||
|
|
||
| export default languages; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to my comments on the Tsonga/Xitsonga labels, there are two possible labels for the Venda language. PFE as of the matching PR 7134, only uses the "Xitsonga" label.
https://en.wikipedia.org/wiki/Venda_language
Again, no changes for this PR or the PFE one, but worth a follow up discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same logic described here applies in this case.