Skip to content

Commit

Permalink
Merge pull request #312 from zowe/doc-string-enforcer
Browse files Browse the repository at this point in the history
Doc string enforcer and annotations
  • Loading branch information
t1m0thyj authored Jul 23, 2024
2 parents aae2eb3 + 711ecd8 commit 297655c
Show file tree
Hide file tree
Showing 28 changed files with 1,181 additions and 763 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/sdk-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install -r requirements.txt
- name: Lint with pydocstyle
run: pydocstyle --match-dir='^(?!build$).*' --match='^(?!(__init__\.py|setup\.py$)).*\.py$' src
- name: Lint with pydoclint
run: pydoclint --exclude='.*/build/.*' src
- name: Lint with flake8
run: |
# stop the build if there are Python syntax errors or undefined names
Expand Down
3 changes: 3 additions & 0 deletions .pydocstyle
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[pydocstyle]
convention = numpy
add-ignore = D107, D207
14 changes: 12 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,31 @@

All notable changes to the Zowe Client Python SDK will be documented in this file.

## Recent Changes

### Enhancements

- Supported for doc string enforcer [#309] (https://github.com/zowe/zowe-client-python-sdk/issues/309)

- Add type annotations for all methods [#280] (https://github.com/zowe/zowe-client-python-sdk/issues/280)

### Bug Fixes

## `1.0.0-dev18`

### Enhancements

- Included support for `AUTH_TYPE_CERT_PEM` and `AUTH_TYPE_NONE` in `session` [#291] (https://github.com/zowe/zowe-client-python-sdk/issues/291) and [#296] (https://github.com/zowe/zowe-client-python-sdk/issues/296)

- Updated all functions descriptions to be consitent [#279] (https://github.com/zowe/zowe-client-python-sdk/issues/279)
- Updated doc strings for all functions to be consistent [#279] (https://github.com/zowe/zowe-client-python-sdk/issues/279)

- *Breaking*: Added Support for turning off loggers. Replaced `setLoggerLevel` in Logger class with `setAllLoggerLevel` [#278] (https://github.com/zowe/zowe-client-python-sdk/issues/278)

### Bug Fixes

- Fixed a bug on `create` in `Datasets` where the target dataset gets created with a different block size when `like` is specified [#295] (https://github.com/zowe/zowe-client-python-sdk/issues/295)

- Fixed a bug on `logger` that it would affect all Python application loggers.
- Fixed a bug on `logger` that it would affect all Python application loggers. [#314] (https://github.com/zowe/zowe-client-python-sdk/issues/314)

## `1.0.0-dev17`

Expand Down
6 changes: 6 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,9 @@ line-length = 120

[tool.isort]
profile = "black"

[tool.pydoclint]
style = "numpy"
check-arg-order = false
require-return-section-when-returning-nothing = false
quiet = true
2 changes: 2 additions & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ mccabe==0.7.0
nose2==0.10.0
pycodestyle==2.9.0
pydocstyle==5.1.1
pydoclint==0.5.3
pyfakefs
pyflakes==2.5.0
pylama==7.7.1
Expand All @@ -37,3 +38,4 @@ zipp==3.19.1
-e ./src/zos_jobs
-e ./src/zos_tso
-e ./src/zosmf

Loading

0 comments on commit 297655c

Please sign in to comment.