-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc string enforcer and annotations #312
Conversation
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
- Coverage 90.11% 89.91% -0.21%
==========================================
Files 53 53
Lines 2773 2816 +43
==========================================
+ Hits 2499 2532 +33
- Misses 274 284 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @pem70
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Peizhao Mei <105866197+pem70@users.noreply.github.com>
Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Peizhao Mei <105866197+pem70@users.noreply.github.com>
Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Peizhao Mei <105866197+pem70@users.noreply.github.com>
Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Peizhao Mei <105866197+pem70@users.noreply.github.com>
Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Peizhao Mei <105866197+pem70@users.noreply.github.com>
Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Peizhao Mei <105866197+pem70@users.noreply.github.com>
Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Peizhao Mei <105866197+pem70@users.noreply.github.com>
Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Peizhao Mei <105866197+pem70@users.noreply.github.com>
Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Peizhao Mei <105866197+pem70@users.noreply.github.com>
Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Peizhao Mei <105866197+pem70@users.noreply.github.com>
Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Peizhao Mei <105866197+pem70@users.noreply.github.com>
Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Peizhao Mei <105866197+pem70@users.noreply.github.com>
Signed-off-by: pem70 <pem70@pitt.edu>
Hey @pem70, When resolving these merge conflicts, remember to remove the To avoid unintentional regressions in the future you can do either of the flowing:
Doing the above should:
|
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
Signed-off-by: pem70 <pem70@pitt.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @pem70!
What It Does
Update current doc strings, introduce doc string check, and update annotation for all methods.
[#279] [#309] [#280]
How to Test
Review Checklist
I certify that I have:
Additional Comments