Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc string enforcer and annotations #312

Merged
merged 48 commits into from
Jul 23, 2024
Merged
Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
c68e2cc
Update doc string
pem70 Jul 12, 2024
d874fef
Update doc string and annotations for files module
pem70 Jul 13, 2024
05a2c57
Update work flow and doc string
pem70 Jul 15, 2024
32f2bfe
Merge branch 'turning-logger-off' into doc-string-enforcer
pem70 Jul 15, 2024
cbe273a
Update CHANGELOG.md
pem70 Jul 15, 2024
ea1d0b6
Update setup and doc string
pem70 Jul 15, 2024
ec578e4
Update pyproject.toml
pem70 Jul 15, 2024
5387d07
Update workflow
pem70 Jul 15, 2024
48c36ab
Update datasets.py
pem70 Jul 15, 2024
545d977
Update files.py
pem70 Jul 15, 2024
de7d963
Update files.py
pem70 Jul 15, 2024
c3db134
Update files.py
pem70 Jul 15, 2024
184cca5
Update sdk-build.yml
pem70 Jul 15, 2024
b5fa04e
Update workflow
pem70 Jul 15, 2024
ff21ab0
Update pyproject.toml
pem70 Jul 15, 2024
b19e4d7
Update config
pem70 Jul 15, 2024
a628408
Update requirements.txt
pem70 Jul 15, 2024
cf940d5
Update config
pem70 Jul 15, 2024
6b1453f
Update requirements.txt
pem70 Jul 15, 2024
f79af4a
Update requirements.txt
pem70 Jul 15, 2024
fe4548f
Update sdk_api.py
pem70 Jul 15, 2024
c1c8833
Update request_handler.py
pem70 Jul 15, 2024
46ea1fa
Update request_handler.py
pem70 Jul 15, 2024
5aac8fb
Update datasets.py
pem70 Jul 15, 2024
18ea511
Update src/core/zowe/core_for_zowe_sdk/profile_manager.py
pem70 Jul 16, 2024
f299361
Update src/core/zowe/core_for_zowe_sdk/session.py
pem70 Jul 16, 2024
28c3062
Update src/zos_files/zowe/zos_files_for_zowe_sdk/uss.py
pem70 Jul 16, 2024
99e8bcf
Resolve Trae's comments
pem70 Jul 16, 2024
ccd0554
Update src/zos_files/zowe/zos_files_for_zowe_sdk/datasets.py
pem70 Jul 18, 2024
7688eb4
Update src/zos_files/zowe/zos_files_for_zowe_sdk/uss.py
pem70 Jul 18, 2024
843ebdc
Update src/zos_files/zowe/zos_files_for_zowe_sdk/uss.py
pem70 Jul 18, 2024
ab2e208
Update CHANGELOG.md
pem70 Jul 18, 2024
e694c29
Update src/zos_files/zowe/zos_files_for_zowe_sdk/datasets.py
pem70 Jul 18, 2024
63e238f
Update src/zos_files/zowe/zos_files_for_zowe_sdk/datasets.py
pem70 Jul 18, 2024
f0d350d
Update src/zos_files/zowe/zos_files_for_zowe_sdk/file_system.py
pem70 Jul 18, 2024
cc28c79
Update src/zos_files/zowe/zos_files_for_zowe_sdk/uss.py
pem70 Jul 18, 2024
75d12d0
Update src/zos_files/zowe/zos_files_for_zowe_sdk/datasets.py
pem70 Jul 18, 2024
08c3312
Update src/zos_files/zowe/zos_files_for_zowe_sdk/file_system.py
pem70 Jul 18, 2024
e20dd68
Update src/zos_files/zowe/zos_files_for_zowe_sdk/file_system.py
pem70 Jul 18, 2024
539925d
Update src/zos_files/zowe/zos_files_for_zowe_sdk/file_system.py
pem70 Jul 18, 2024
3045504
Update datasets.py
pem70 Jul 18, 2024
1290c78
Merge branch 'main' into doc-string-enforcer
pem70 Jul 18, 2024
8d030a2
Merge branch 'main' into doc-string-enforcer
pem70 Jul 19, 2024
d01f085
Update CHANGELOG.md
pem70 Jul 19, 2024
a8e6d95
Update CHANGELOG.md
pem70 Jul 19, 2024
1cca450
Update logger.py
pem70 Jul 19, 2024
a04dde5
Update logger.py
pem70 Jul 19, 2024
711ecd8
Update datasets.py
pem70 Jul 22, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/sdk-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install -r requirements.txt
- name: Lint with pydocstyle
run: pydocstyle --match-dir='^(?!build$).*' --match='^(?!(__init__\.py|setup\.py$)).*\.py$' src
- name: Lint with pydoclint
run: pydoclint --exclude='.*/build/.*' src
- name: Lint with flake8
run: |
# stop the build if there are Python syntax errors or undefined names
Expand Down
3 changes: 3 additions & 0 deletions .pydocstyle
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[pydocstyle]
convention = numpy
add-ignore = D107, D207
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ All notable changes to the Zowe Client Python SDK will be documented in this fil

- *Breaking*: Added Support for turning off loggers. Replaced `setLoggerLevel` in Logger class with `setAllLoggerLevel` [#278] (https://github.com/zowe/zowe-client-python-sdk/issues/278)

- Supported for doc string enforcer [#309] (https://github.com/zowe/zowe-client-python-sdk/issues/309)

- Add type annotations for all methods [#280] (https://github.com/zowe/zowe-client-python-sdk/issues/280)

### Bug Fixes

- Fixed a bug on `create` in `Datasets` where the target dataset gets created with a different block size when `like` is specified [#295] (https://github.com/zowe/zowe-client-python-sdk/issues/295)
Expand Down
6 changes: 6 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,9 @@ line-length = 120

[tool.isort]
profile = "black"

[tool.pydoclint]
style = "numpy"
check-arg-order = false
require-return-section-when-returning-nothing = false
quiet = true
2 changes: 2 additions & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ mccabe==0.7.0
nose2==0.10.0
pycodestyle==2.9.0
pydocstyle==5.1.1
pydoclint==0.5.3
pyfakefs
pyflakes==2.5.0
pylama==7.7.1
Expand All @@ -37,3 +38,4 @@ zipp==3.19.1
-e ./src/zos_jobs
-e ./src/zos_tso
-e ./src/zosmf

Loading
Loading