Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent search JOB filter does not work #2562

Closed
Felix-Braun opened this issue Nov 10, 2023 · 5 comments
Closed

Recent search JOB filter does not work #2562

Felix-Braun opened this issue Nov 10, 2023 · 5 comments
Assignees
Labels
bug Something isn't working priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex.

Comments

@Felix-Braun
Copy link

Describe the bug

If I search for JOBS, there are two options.

  1. search job by search filter (Owner: * | Prefix: * | Status: *)
  2. search job by job ID

My recent Filters, with I used are shown. If I use a recent Filter from option "job search filter" it does relay, but if I try to use a Job ID as a recent Filter, it opens the option "create job search filter" with the standard values.

To Reproduce

Expected behavior
It relays the Job ID instead of creating a new job search filter.

Screenshots
job_search_filter

Desktop (please complete the following information):

OS: Windows 10
Zowe Explorer Version: 2.12.1
(Optional) Zowe CLI Version: 7.18.9
(Optional) Are you using Secure Credential Store? Yes

@Felix-Braun Felix-Braun added the bug Something isn't working label Nov 10, 2023
Copy link

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@adam-wolfe adam-wolfe added priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex. labels Nov 21, 2023
@jellypuno
Copy link
Contributor

Hallo! I want to work on this. Can I take it?

@zFernand0
Copy link
Member

Hey @jellypuno,
Nice to hear from you 😋
Go right ahead! 🥳

@jellypuno
Copy link
Contributor

Notes:
Error happens in ZosJobsProvider.ts; somewhere around line 722

        if (menuType === History) {
            const parsedHistory = this.parseJobSearchQuery(choice.label);
            if (parsedHistory.JobId) {
                return this.handleSearchByJobId(parsedHistory.JobId);
            } else {
                const quickPickPrefilledItems = this.getPopulatedPickerValues(parsedHistory);
                return this.handleEditingMultiJobParameters(quickPickPrefilledItems, node);
            }
        }
    }

@traeok
Copy link
Member

traeok commented Jan 16, 2024

Fixed and completed in #2658

@traeok traeok closed this as completed Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex.
Projects
Status: Closed
Development

No branches or pull requests

5 participants