Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 2562: Change the value of the variable JobId from Job ID to JobId #2658

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

jellypuno
Copy link
Contributor

@jellypuno jellypuno commented Jan 10, 2024

Proposed changes

The problem happened because of the persisted key "Job ID" in the history. In parseJobSearchQuery, the constant searchCriteriaObj expects that the key should be JobId. Since the format is wrong then it is populated properly.

        const searchCriteriaObj: IJobSearchCriteria = {
            Owner: undefined,
            Prefix: undefined,
            JobId: undefined,
            Status: undefined,
        };

To fix this, I just need to change the value of public static readonly JobId from Job ID: to JobId:

Before the changes:
fix2562_Before

After the changes:
fix2562_After

Release Notes

Milestone:

Changelog:
Fix Issue 2562: Change the value of the variable JobId from Job ID to JobId

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Signed-off-by: Jessielaine Punongbayan <jelly.puno@gmail.com>
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d0c333c) 93.30% compared to head (e4537e6) 93.30%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2658   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files         102      102           
  Lines       10506    10506           
  Branches     2251     2251           
=======================================
  Hits         9803     9803           
  Misses        702      702           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jessielaine Punongbayan <jelly.puno@gmail.com>
Copy link

sonarcloud bot commented Jan 10, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@JillieBeanSim JillieBeanSim self-requested a review January 11, 2024 13:29
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jellypuno it is so good to hear from you 👋🏻 . Thanks so much for the fix, it LGTM!

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM! Thanks for the bug fix @jellypuno 😁

@traeok traeok merged commit 2b723f3 into zowe:main Jan 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants