Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Make initForZowe argument profileTypeConfigurations required #2659

Merged
merged 4 commits into from
Jan 12, 2024

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Jan 12, 2024

Proposed changes

make initForZowe argument profileTypeConfigurations required

Release Notes

Milestone: vNext

Changelog:

  • Changed IApiExplorerExtenders.initForZowe profileTypeConfigurations: imperative.ICommandProfileTypeConfiguration[] to a required argument to address issues seen after registration of profile type when not passed. #2575
  • Changed ZoweExplorerExtender.initForZowe profileTypeConfigurations: imperative.ICommandProfileTypeConfiguration[] to a required argument to address issues seen after registration of profile type when not passed. #2575

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@JillieBeanSim JillieBeanSim added API Extender Issues that allow Zowe Explorer to be extended externally v3 Breaking Change labels Jan 12, 2024
@JillieBeanSim JillieBeanSim added this to the v3 pre-releases milestone Jan 12, 2024
@JillieBeanSim JillieBeanSim self-assigned this Jan 12, 2024
@JillieBeanSim JillieBeanSim changed the base branch from next to publish/3.0.0-next-prerelease January 12, 2024 14:00
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72dcc54) 93.42% compared to head (3615eb0) 93.42%.
Report is 2 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2659   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files         109      109           
  Lines       10237    10237           
  Branches     2134     2134           
=======================================
  Hits         9564     9564           
  Misses        672      672           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JillieBeanSim JillieBeanSim linked an issue Jan 12, 2024 that may be closed by this pull request
Base automatically changed from publish/3.0.0-next-prerelease to next January 12, 2024 17:46
@JillieBeanSim JillieBeanSim marked this pull request as ready for review January 12, 2024 18:37
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JillieBeanSim!

@zFernand0 zFernand0 merged commit 4a74ce6 into next Jan 12, 2024
28 checks passed
@zFernand0 zFernand0 deleted the remove-optional-param branch January 12, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Extender Issues that allow Zowe Explorer to be extended externally Breaking Change v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema parameter not really optional
4 participants