-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3] Make initForZowe argument profileTypeConfigurations required #2659
Conversation
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2659 +/- ##
=======================================
Coverage 93.42% 93.42%
=======================================
Files 109 109
Lines 10237 10237
Branches 2134 2134
=======================================
Hits 9564 9564
Misses 672 672
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JillieBeanSim!
Proposed changes
make initForZowe argument profileTypeConfigurations required
Release Notes
Milestone: vNext
Changelog:
profileTypeConfigurations: imperative.ICommandProfileTypeConfiguration[]
to a required argument to address issues seen after registration of profile type when not passed. #2575profileTypeConfigurations: imperative.ICommandProfileTypeConfiguration[]
to a required argument to address issues seen after registration of profile type when not passed. #2575Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments