Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Make initForZowe argument profileTypeConfigurations required #2659

Merged
merged 4 commits into from
Jan 12, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/early-access/v3/Extenders.md
Original file line number Diff line number Diff line change
@@ -15,6 +15,8 @@
- `ZoweVsCodeExtension.showVsCodeMessage` removed in favor of `Gui.showMessage`.
- `ZoweVsCodeExtension.inputBox` removed in favor of `Gui.showInputBox`.
- `ZoweVsCodeExtension.promptCredentials` removed in favor of `ZoweVsCodeExtension.updateCredentials`.
- Changed ZoweExplorerExtender.initForZowe `profileTypeConfigurations: imperative.ICommandProfileTypeConfiguration[]` to a required argument
- Changed IApiExplorerExtenders.initForZowe `profileTypeConfigurations: imperative.ICommandProfileTypeConfiguration[]` to a required argument

## New APIs Added

6 changes: 6 additions & 0 deletions packages/eslint-plugin-zowe-explorer/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
All notable changes to the "eslint-plugin-zowe-explorer" package will be documented in this file.

## TBD Release

### New features and enhancements

### Bug fixes

## `3.0.0-next.202401121747`

## `3.0.0-next.202311171754`
8 changes: 8 additions & 0 deletions packages/zowe-explorer-api/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -2,6 +2,14 @@

All notable changes to the "zowe-explorer-api" extension will be documented in this file.

## TBD Release

### New features and enhancements

### Bug fixes

- Changed IApiExplorerExtenders.initForZowe `profileTypeConfigurations: imperative.ICommandProfileTypeConfiguration[]` to a required argument to address issues seen after registration of profile type when not passed. [#2575](https://github.com/zowe/vscode-extension-for-zowe/issues/2575)

## `3.0.0-next.202401121747`

### New features and enhancements
Original file line number Diff line number Diff line change
@@ -44,5 +44,5 @@ export interface IApiExplorerExtender {
* might want to check for an existing profile folder with meta-file
* or to create them automatically if it is non-existant.
*/
initForZowe(type: string, profileTypeConfigurations?: imperative.ICommandProfileTypeConfiguration[]): Promise<void>;
initForZowe(type: string, profileTypeConfigurations: imperative.ICommandProfileTypeConfiguration[]): Promise<void>;
}
6 changes: 6 additions & 0 deletions packages/zowe-explorer-ftp-extension/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
All notable changes to the "zowe-explorer-ftp-extension" extension will be documented in this file.

## TBD Release

### New features and enhancements

### Bug fixes

## `3.0.0-next.202401121747`

### Bug fixes
8 changes: 8 additions & 0 deletions packages/zowe-explorer/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -2,6 +2,14 @@

All notable changes to the "vscode-extension-for-zowe" extension will be documented in this file.

## TBD Release

### New features and enhancements

### Bug fixes

- Changed ZoweExplorerExtender.initForZowe `profileTypeConfigurations: imperative.ICommandProfileTypeConfiguration[]` to a required argument to address issues seen after registration of profile type when not passed. [#2575](https://github.com/zowe/vscode-extension-for-zowe/issues/2575)

## `3.0.0-next.202401121747`

### New features and enhancements
2 changes: 1 addition & 1 deletion packages/zowe-explorer/src/ZoweExplorerExtender.ts
Original file line number Diff line number Diff line change
@@ -149,7 +149,7 @@ export class ZoweExplorerExtender implements IApiExplorerExtender, ZoweExplorerT
* @param {string} profileType
* @param {imperative.ICommandProfileTypeConfiguration[]} profileTypeConfigurations
*/
public async initForZowe(profileType: string, profileTypeConfigurations?: zowe.imperative.ICommandProfileTypeConfiguration[]): Promise<void> {
public async initForZowe(profileType: string, profileTypeConfigurations: zowe.imperative.ICommandProfileTypeConfiguration[]): Promise<void> {
// Ensure that when a user has not installed the profile type's CLI plugin
// and/or created a profile that the profile directory in ~/.zowe/profiles
// will be created with the appropriate meta data. If not called the user will