Fix downloading spool files failing to match tree nodes

[t1m0thyj]

Proposed changes

Fixes bug where nothing happens when trying to download spool files in the ZE jobs tree.

Release Notes

Milestone: 2.17.0

Changelog: Fixed issue where Download Spool action could fail to find spool files to download

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

• I have read the CONTRIBUTOR GUIDANCE wiki
• PR title follows Conventional Commits Guidelines
• PR Description is included
• gif or screenshot is included if visual changes are made
• yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
• All checks have passed (DCO, Jenkins and Code Coverage)
• I have added unit test and it is passing
• I have added integration test and it is passing
• There is coverage for the code that I have added
• I have tested it manually and there are no regressions found
• I have added necessary documentation (if appropriate)
• Any PR dependencies have been merged and published (if appropriate)

Further comments

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.48%. Comparing base (88a7257) to head (b58a6d6).

❗ Current head b58a6d6 differs from pull request most recent head 1398351

Please upload reports for the commit 1398351 to get more accurate results.

Additional details and impacted files

@@             Coverage Diff              @@
##           maintenance    #2943   +/-   ##
============================================
  Coverage        93.48%   93.48%           
============================================
  Files              104      104           
  Lines            10842    10843    +1     
  Branches          2360     2371   +11     
============================================
+ Hits             10136    10137    +1     
  Misses             705      705           
  Partials             1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[anaxceron]

great!

[traeok]

LGTM, thanks for the fix @t1m0thyj!

[zFernand0]

LGTM! 😋

---

Related to:

• Download.dataset partially downloads ( corrupts) files? zowe-cli#744
• Fix error when downloading spool files with default encoding zowe-cli#2173

[sonarcloud]

Quality Gate failed

Failed conditions
20.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

[JillieBeanSim]

LGTM! thanks for fix @t1m0thyj I was able to recreate with marketplace and see the fix on branch 😄

[JillieBeanSim]

@t1m0thyj do we have a ZE issue that can be tied to PR/milestone?

[t1m0thyj]

@JillieBeanSim I've created one: #2957