-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(profiles): Pass homeDir, projectDir
when creating ProfileInfo
instance
#3169
Conversation
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
homeDir
and projectDir
when creating ProfileInfo
instancehomeDir, projectDir
when creating ProfileInfo
instance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3169 +/- ##
==========================================
+ Coverage 92.79% 92.81% +0.01%
==========================================
Files 113 113
Lines 11670 11672 +2
Branches 2603 2609 +6
==========================================
+ Hits 10829 10833 +4
+ Misses 839 837 -2
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
📅 Suggested merge-by date: 10/16/2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple comments re: changelog.
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @traeok!
Proposed changes
Fixed a bug where a new
ProfileInfo
instance was being created when initializing Zowe profiles, but that instance was missing thehomeDir
andprojectDir
from its constructor options.Release Notes
Milestone: 3.0.1
Changelog:
ProfilesUtils.getProfileInfo
function returned a newProfileInfo
instance that ignored theZOWE_CLI_HOME
environment variable and workspace paths. #3168Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
v2-lts