Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] fix(profiles): Pass homeDir, projectDir when creating ProfileInfo instance #3170

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented Oct 2, 2024

Proposed changes

Fixed a bug where a new ProfileInfo instance was being created when initializing Zowe profiles, but that instance was missing the homeDir and projectDir from its constructor options.

Release Notes

Milestone: 2.18.1

Changelog:

  • Fixed an issue where ProfilesUtils.getProfileInfo returned a new ProfileInfo instance that did not respect the home directory or workspace paths. #3168

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Copy link

sonarcloud bot commented Oct 2, 2024

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.32%. Comparing base (1a5ac1f) to head (f4578f0).
Report is 1 commits behind head on v2-lts.

Additional details and impacted files
@@           Coverage Diff           @@
##           v2-lts    #3170   +/-   ##
=======================================
  Coverage   93.32%   93.32%           
=======================================
  Files         105      105           
  Lines       11077    11079    +2     
  Branches     2391     2393    +2     
=======================================
+ Hits        10338    10340    +2     
  Misses        738      738           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@traeok traeok marked this pull request as ready for review October 2, 2024 18:33
Copy link

github-actions bot commented Oct 2, 2024

📅 Suggested merge-by date: 10/16/2024

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick port 😋

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @traeok for the fix

@JillieBeanSim JillieBeanSim merged commit d090118 into v2-lts Oct 3, 2024
23 checks passed
@JillieBeanSim JillieBeanSim deleted the fix/v2/profileinfo branch October 3, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants