fix(ds): Pass correct DS name in `stat` when doing remote lookup #3407

traeok · 2025-01-22T16:37:48Z

Proposed changes

Release Notes

Milestone:

Changelog:

Types of changes

Bug fix (non-breaking change which fixes an issue)
Enhancement (non-breaking change which adds or improves functionality)
Breaking change (a change that would cause existing functionality to not work as expected)
Documentation (Markdown, README updates)
Other (please specify above in "Proposed changes" section)

Checklist

General

I have read the CONTRIBUTOR GUIDANCE wiki
All PR dependencies have been merged and published (if applicable)
A GIF or screenshot is included in the PR for visual changes
The pre-publish command has been executed:
- v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
- v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

There is coverage for the code that I have added
I have added new test cases and they are passing
I have manually tested the changes

Deployment

I have added developer documentation (if applicable)
Documentation should be added to Zowe Docs
- If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
- Otherwise, please check with the rest of the squad about any needed documentation before merging.
These changes may need ported to the appropriate branches (list here):

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

codecov · 2025-01-22T16:39:08Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (4fefdf9) to head (e495aba).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #3407    +/-   ##
========================================
  Coverage   93.18%   93.18%            
========================================
  Files         120      120            
  Lines       12502    12503     +1     
  Branches     2885     2761   -124     
========================================
+ Hits        11650    11651     +1     
  Misses        851      851            
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

github-actions · 2025-01-22T16:40:27Z

📅 Suggested merge-by date: 2/5/2025

t1m0thyj

LGTM, thanks @traeok!

zFernand0

Apologies for the late review ❤️
LGTM! 😋

* fix: use path.basename and helper fn to extract DS name Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * test: add unit test to verify proper DS name Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: update changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

* update lerna and remove un-needed changelog headers Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * add notes to readme's of VSC for older releases location with link Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * run package command Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * chore: downgrade ubuntu runners to ubuntu-22.04 Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix: call Mutex.waitForUnlock instead of locking profile before request (#3409) * fix: call Mutex.waitForUnlock instead of locking profile before request Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix: AuthHandler.waitForUnlock Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests: AuthHandler.waitForUnlock Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix: add true opt-in support for profile locks w/ extender types Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix(ds): Pass correct DS name in `stat` when doing remote lookup (#3407) * fix: use path.basename and helper fn to extract DS name Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * test: add unit test to verify proper DS name Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: update changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> --------- Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

* run l10n prepublish script Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix: Avoid data-loss when creating new members (#3392) (#3397) * fix: Avoid data-loss when creating new members (#3392) * fix: Prompt users when creating members if the member exists Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * review: alternative way Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * test: add coverage for added memberFound logic Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * chore: update changelog Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * chore: cleanup commented code Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * chore: simplify fix 😋 Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * Update packages/zowe-explorer/CHANGELOG.md Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> --------- Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: move the changelog entry to the right location Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> --------- Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> * Fix internal error when extenders register new profile types (#3412) (#3416) * Fix internal error when extenders register new profile types (#3412) Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * chore: downgrade ubuntu runners to ubuntu-22.04 (#3406) Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> * Prepare 3.1.0 release (#3398) * update lerna and remove un-needed changelog headers Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * add notes to readme's of VSC for older releases location with link Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * run package command Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * chore: downgrade ubuntu runners to ubuntu-22.04 Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix: call Mutex.waitForUnlock instead of locking profile before request (#3409) * fix: call Mutex.waitForUnlock instead of locking profile before request Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix: AuthHandler.waitForUnlock Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests: AuthHandler.waitForUnlock Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix: add true opt-in support for profile locks w/ extender types Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix(ds): Pass correct DS name in `stat` when doing remote lookup (#3407) * fix: use path.basename and helper fn to extract DS name Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * test: add unit test to verify proper DS name Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: update changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> --------- Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * fix: update release config to allow minor release (#3419) Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * Bump version to 3.1.0 [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * Bump version to 3.2.0-SNAPSHOT [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * update CHANGELOGS Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * chore: move recently merged PR into the tbd release section Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Third-Party DCO Remediation Commit for Billie Simmons <BillieJean.Simmons@ibm.com> On behalf of Billie Simmons <BillieJean.Simmons@ibm.com>, I, Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 0efa5bb Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * fix: correct expected value in createZoweSchema test Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> Signed-off-by: zowe-robot <zowe.robot@gmail.com> Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Co-authored-by: zowe-robot <zowe.robot@gmail.com>

traeok added 2 commits January 22, 2025 11:31

fix: use path.basename and helper fn to extract DS name

aa9c6ce

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

test: add unit test to verify proper DS name

90f79de

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

pull-request-size bot added the size/M label Jan 22, 2025

github-actions bot assigned traeok Jan 22, 2025

chore: update changelog

5aa9fa3

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

traeok marked this pull request as ready for review January 22, 2025 16:40

traeok requested review from t1m0thyj, zFernand0, JillieBeanSim, awharn, rudyflores, anaxceron, SanthoshiBoyina1 and likhithanimma1 January 22, 2025 16:40

t1m0thyj approved these changes Jan 23, 2025

View reviewed changes

Merge branch 'main' into fix/ds/remove-ext-during-list

e495aba

zFernand0 approved these changes Jan 24, 2025

View reviewed changes

anaxceron approved these changes Jan 24, 2025

View reviewed changes

t1m0thyj merged commit 94ffb67 into main Jan 25, 2025
33 checks passed

t1m0thyj deleted the fix/ds/remove-ext-during-list branch January 25, 2025 11:41

JillieBeanSim mentioned this pull request Feb 4, 2025

v3.1.1 Release Plan #3434

Open

JillieBeanSim modified the milestone: v3.1.1 Feb 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ds): Pass correct DS name in `stat` when doing remote lookup #3407

fix(ds): Pass correct DS name in `stat` when doing remote lookup #3407

traeok commented Jan 22, 2025 •

edited

Loading

codecov bot commented Jan 22, 2025 •

edited

Loading

github-actions bot commented Jan 22, 2025

t1m0thyj left a comment

zFernand0 left a comment

fix(ds): Pass correct DS name in stat when doing remote lookup #3407

fix(ds): Pass correct DS name in stat when doing remote lookup #3407

Conversation

traeok commented Jan 22, 2025 • edited Loading

Proposed changes

Release Notes

Types of changes

Checklist

codecov bot commented Jan 22, 2025 • edited Loading

Codecov Report

github-actions bot commented Jan 22, 2025

t1m0thyj left a comment

Choose a reason for hiding this comment

zFernand0 left a comment

Choose a reason for hiding this comment

fix(ds): Pass correct DS name in `stat` when doing remote lookup #3407

fix(ds): Pass correct DS name in `stat` when doing remote lookup #3407

traeok commented Jan 22, 2025 •

edited

Loading

codecov bot commented Jan 22, 2025 •

edited

Loading