Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix internal error when extenders register new profile types (#3412) #3416

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Fix internal error when extenders register new profile types (#3412) #3416

merged 2 commits into from
Jan 27, 2025

Conversation

zFernand0
Copy link
Member

Copied from:

Proposed changes

Fixes this error which appears in ZE V3 when running the USS Profile Sample extension:

Image

Release Notes

Milestone: 3.1.0

Changelog: Fixed an issue where registering new profile types from a Zowe Explorer extender could cause an internal API error on startup

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

@github-actions GitHub Actions
Copy link

📅 Suggested merge-by date: 2/10/2025

@codecov Codecov
Copy link

codecov bot commented Jan 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.19%. Comparing base (f2e6c59) to head (82e8af6).
Report is 1 commits behind head on release/3.1.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release/3.1    #3416      +/-   ##
===============================================
+ Coverage        93.18%   93.19%   +0.01%     
===============================================
  Files              120      120              
  Lines            12490    12499       +9     
  Branches          2871     2763     -108     
===============================================
+ Hits             11639    11649      +10     
+ Misses             850      849       -1     
  Partials             1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zFernand0 zFernand0 changed the base branch from prepare-3.1.0 to release/3.1 January 27, 2025 14:37
@t1m0thyj @zFernand0
Fix internal error when extenders register new profile types (#3412)
597fa21 
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
@traeok @zFernand0
chore: downgrade ubuntu runners to ubuntu-22.04 (#3406)
82e8af6 
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
JillieBeanSim
JillieBeanSim approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for porting the fix LGTM

@JillieBeanSim JillieBeanSim merged commit d7c1554 into release/3.1 Jan 27, 2025
31 checks passed
@JillieBeanSim JillieBeanSim deleted the cp-3412 branch January 27, 2025 15:17
zFernand0 added a commit that referenced this pull request Feb 3, 2025
@JillieBeanSim @traeok
@zFernand0 @t1m0thyj @zowe-robot
Port 3.1.0 release changes to main (#3421)
54044bf 
* run l10n prepublish script

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

* fix: Avoid data-loss when creating new members (#3392) (#3397)

* fix: Avoid data-loss when creating new members (#3392)

* fix: Prompt users when creating members if the member exists

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

* review: alternative way

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

* test: add coverage for added memberFound logic

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

* chore: update changelog

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

* chore: cleanup commented code

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

* chore: simplify fix 😋

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

* Update packages/zowe-explorer/CHANGELOG.md

Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

---------

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com>

* chore: move the changelog entry to the right location

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

---------

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com>

* Fix internal error when extenders register new profile types (#3412) (#3416)

* Fix internal error when extenders register new profile types (#3412)

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

* chore: downgrade ubuntu runners to ubuntu-22.04 (#3406)

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

---------

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com>
Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com>

* Prepare 3.1.0 release (#3398)

* update lerna and remove un-needed changelog headers

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

* add notes to readme's of VSC for older releases location with link

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

* run package command

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

* chore: downgrade ubuntu runners to ubuntu-22.04

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

* fix: call Mutex.waitForUnlock instead of locking profile before request (#3409)

* fix: call Mutex.waitForUnlock instead of locking profile before request

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

* fix: AuthHandler.waitForUnlock

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

* tests: AuthHandler.waitForUnlock

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

* fix: add true opt-in support for profile locks w/ extender types

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

---------

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

* fix(ds): Pass correct DS name in `stat` when doing remote lookup (#3407)

* fix: use path.basename and helper fn to extract DS name

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

* test: add unit test to verify proper DS name

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

* chore: update changelog

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

---------

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

---------

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com>
Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com>
Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

* fix: update release config to allow minor release (#3419)

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

* Bump version to 3.1.0 [ci skip]

Signed-off-by: zowe-robot <zowe.robot@gmail.com>

* Bump version to 3.2.0-SNAPSHOT [ci skip]

Signed-off-by: zowe-robot <zowe.robot@gmail.com>

* update CHANGELOGS

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

* chore: move recently merged PR into the tbd release section

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

Third-Party DCO Remediation Commit for Billie Simmons <BillieJean.Simmons@ibm.com>

On behalf of Billie Simmons <BillieJean.Simmons@ibm.com>, I, Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 0efa5bb

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

* fix: correct expected value in createZoweSchema test

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

---------

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: zowe-robot <zowe.robot@gmail.com>
Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com>
Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com>
Co-authored-by: zowe-robot <zowe.robot@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t1m0thyj t1m0thyj t1m0thyj approved these changes

@JillieBeanSim JillieBeanSim JillieBeanSim approved these changes

@traeok traeok Awaiting requested review from traeok

@SanthoshiBoyina1 SanthoshiBoyina1 Awaiting requested review from SanthoshiBoyina1

@likhithanimma1 likhithanimma1 Awaiting requested review from likhithanimma1

Assignees

@zFernand0 zFernand0

Labels
size/L
Projects
Zowe Explorer for VS Code
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zFernand0 @t1m0thyj @JillieBeanSim @traeok