Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msglist: In single-conversation view, make recipient headers not tappable #1171

Open
chrisbobbe opened this issue Dec 18, 2024 · 5 comments
Open
Assignees
Labels
a-msglist The message-list screen, except what's label:a-content beta feedback Things beta users have specifically asked for

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Dec 18, 2024

Copying from CZO, where Greg said:

@_Anders Kaseorg|699 said:

By repeatedly tapping on a message header bar, one can add arbitrarily many frames to the navigation stack

Separately, it'd probably be good to fix the fact that it's so easy to do that in a loop. When you're already looking at a given page, there's not much value in pushing a new copy of the same page onto the navigation stack.

So, concretely, if you're looking at a message list for a single conversation (either topic or DMs), the recipient header probably shouldn't be clickable to navigate redundantly to the same conversation.

Mostly the recipient header itself is redundant in that case, and Vlad's design calls for changing it: #1039. But there are a couple of open questions there, and perhaps in the meantime as a quick fix we should just make it not clickable.

@chrisbobbe chrisbobbe added a-msglist The message-list screen, except what's label:a-content beta feedback Things beta users have specifically asked for labels Dec 18, 2024
@chrisbobbe
Copy link
Collaborator Author

@gnprice gnprice added this to the M6: Post-launch milestone Dec 18, 2024
@lakshya1goel
Copy link

Hey, I want to work on this.

@lakshya1goel
Copy link

Hey, here is the screen recording of the implementation.

WhatsApp.Video.2024-12-20.at.9.28.48.PM.mp4

@chrisbobbe
Copy link
Collaborator Author

Thanks! I've assigned this issue to you; I'm eager to see a PR.

@lakshya1goel
Copy link

@chrisbobbe I have raised the PR. Please review it and let me know if anything else needed.

lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Dec 21, 2024
…able.

Updated onTap for recipient headers in single-conversation view.
Adjusted GestureDetector logic to conditionally enable navigation.
Simplified ColoredBox structure for non-tappable recipient headers.
Improves user experience by removing unnecessary tap interactions.

Fixes: zulip#1171
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Dec 21, 2024
…able.

Updated onTap for recipient headers in single-conversation view.
Adjusted GestureDetector logic to conditionally enable navigation.
Simplified ColoredBox structure for non-tappable recipient headers.
Improves user experience by removing unnecessary tap interactions.

Fixes: zulip#1171
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Dec 22, 2024
…able.

Updated onTap for recipient headers in single-conversation view.
Adjusted GestureDetector logic to conditionally enable navigation.
Simplified ColoredBox structure for non-tappable recipient headers.
Improves user experience by removing unnecessary tap interactions.

Fixes: zulip#1171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-msglist The message-list screen, except what's label:a-content beta feedback Things beta users have specifically asked for
Projects
Status: No status
Development

No branches or pull requests

3 participants