msglist: In single-conversation view, make recipient headers not tappable. #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
requested changes
Dec 20, 2024
lakshya1goel
force-pushed
the
issue1171
branch
2 times, most recently
from
59f7f42 to
eb6a565
Compare
|
@chrisbobbe Please have a look on the changes now. Added tests as well. But getting the CI/check fails, showing Please let me know how can I fix them, as I have the good internet connectivity still getting this. |
…able. Updated onTap for recipient headers in single-conversation view. Adjusted GestureDetector logic to conditionally enable navigation. Simplified ColoredBox structure for non-tappable recipient headers. Improves user experience by removing unnecessary tap interactions. Fixes: zulip#1171
lakshya1goel
force-pushed
the
issue1171
branch
from
eb6a565 to
1b99395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Summary
This PR updates the behavior of recipient headers in the single-conversation view to make them non-tappable.
Related Issue: #1171
Changes:
Adjusted GestureDetector logic:
Updated the logic to conditionally enable navigation only when relevant.
Simplified ColoredBox structure:
Streamlined the layout for non-tappable headers to ensure consistent behavior and appearance.
Video Demonstration:
WhatsApp.Video.2024-12-20.at.10.39.41.PM.mp4