-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build an asset font for custom icons #200
Comments
The custom icons we'll want are those in Potentially we might also want to include other icons not found there. One known place where we'll want to use a custom icon is in #119, in the spot that replaces an avatar for group DM threads; see chat thread. If we write this script after #119 is already done, then we'll have some other icon there initially and we'll want to replace it with the custom icon. |
This serves as a demo of our custom icon font zulip#200.
In #219 I went for the latter. I looked in a couple of directions for leads on alternative tools to use, but didn't find anything helpful:
So with #219 we'll have one subdirectory with a tiny |
This serves as a demo of our custom icon font zulip#200.
This serves as a demo of our custom icon font zulip#200.
Much like we do in zulip-mobile and Zulip web. We'll want a font file containing the icons, and then a generated Dart file that maps icon names to glyph IDs in the font.
For references, see:
tools/build-icon-font
in zulip-mobile, which is a Node script doing a similar job using the NPM package@vusion/webfonts-generator
It would be nice if we can write the script purely in Dart. If we can't readily lay hands on appropriate tools to make that easy, we could settle for having a Node script so that we can use NPM packages.
The generated output — both the font file and the generated Dart file — should be committed to the repo, just like we do for other generated files and just like we do for the corresponding files in zulip-mobile. That way the script only has to be run when changing the set of icons, and there's no complication added to a normal development cycle.
The text was updated successfully, but these errors were encountered: