Closed
Description
This is a followup to these two issues:
Our original implementation of #119, the list of recent DM conversations, didn't show the unread counts, because we didn't yet have the data model #253 for them. Once we have that data model, we should add that UI.
For the design, see #119, in particular #119 (comment) and @terpimost's Figma design at https://www.figma.com/file/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?type=design&node-id=442-18279&mode=design&t=4gzhffidomEdPbSt-0 .
Metadata
Metadata
Assignees
Type
Projects
Status
Done
Activity
chrisbobbe commentedon Oct 24, 2023
Greg, @terpimost, do we want to show an "@" sign when the conversation has an unread @-mention in it, as is the norm when showing unreads for streams/topics? It looks like we don't have those for DMs in zulip-mobile or in the web app, but it seems like a nice thing to offer.
There's an SVG "@" sign icon in Figma (taken from a design for a streams/topics list):
and I think that would be easy to bring in with
tools/build-icon-font
. Vlad, is that a Zulip custom icon that's ready to be used?gnprice commentedon Oct 24, 2023
My inclination is no — if you send someone a DM, that's already meant to be as high an indication that you specifically want their attention as an @-mention would be.
I guess the indicator could be helpful for some group threads where there's a lot of discussion that's only immediately actionable for some of the people in the thread. But really the right answer in that situation is to make a stream.
RecentDmConversationsPage: Show unread counts
alya commentedon Oct 26, 2023
Yeah, not showing @ in DMs was an intentional choice in the web app for exactly the reason Greg described.
RecentDmConversationsPage: Show unread counts
RecentDmConversationsPage: Show unread counts
RecentDmConversationsPage: Show unread counts
RecentDmConversationsPage: Show unread counts
RecentDmConversationsPage: Show unread counts