Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msglist/dm: Provide proper feedback when sending DMs to a deactivated user #675

Closed
sm-sayedi opened this issue May 14, 2024 · 1 comment · Fixed by #816
Closed

msglist/dm: Provide proper feedback when sending DMs to a deactivated user #675

sm-sayedi opened this issue May 14, 2024 · 1 comment · Fixed by #816
Assignees
@sm-sayedi
Labels
a-compose Compose box, autocomplete, attaching files/images
Milestone
M3: Summer 2024

Comments

@sm-sayedi
Copy link
Collaborator

sm-sayedi commented May 14, 2024 •
edited
Loading

When trying to send a DM message to a deactivated user, the message goes into void and nothing happens so the user knows they're exchanging messages with a deactivated user.

Here's how it looks right now:



This is how the web handles it:

The react-native mobile app just shows an infinite loading indicator on the right side of the message.
@gnprice gnprice added this to the Beta 3: Summer 2024 milestone May 14, 2024
@gnprice gnprice added the a-compose Compose box, autocomplete, attaching files/images label May 14, 2024
@gnprice
Copy link
Member

gnprice commented May 14, 2024

Thanks! Agreed, we should fix this.

@gnprice gnprice mentioned this issue Jul 6, 2024
Open
@gnprice gnprice mentioned this issue Jul 16, 2024
Closed
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 16, 2024
@sm-sayedi
compose_box: Disable the compose box in DMs with deactivated users
b6023ad 
Fixes: zulip#675
@sm-sayedi sm-sayedi mentioned this issue Jul 16, 2024
Merged
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 16, 2024
@sm-sayedi
compose_box: Disable the compose box in DMs with deactivated users
616322c 
Fixes: zulip#675
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 17, 2024
@sm-sayedi
compose_box: Disable the compose box in DMs with deactivated users
4d106d6 
Fixes: zulip#675
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 18, 2024
@sm-sayedi
compose_box: Disable the compose box in DMs with deactivated users
3c48c68 
Fixes: zulip#675
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 22, 2024
@sm-sayedi @rajveermalviya
compose_box: Disable the compose box in DMs with deactivated users
c7a442f 
Fixes: zulip#675

Co-authored-by: Rajesh Malviya <rajveer0malviya@gmail.com>
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 25, 2024
@sm-sayedi @rajveermalviya
compose_box: Replace compose box with a banner in DMs with deactivate…
2fca6a5 
…d users

Fixes: zulip#675

Co-authored-by: Rajesh Malviya <rajveer0malviya@gmail.com>
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 26, 2024
@sm-sayedi @rajveermalviya
compose_box: Replace compose box with a banner in DMs with deactivate…
d06abe7 
…d users

Fixes: zulip#675

Co-authored-by: Rajesh Malviya <rajveer0malviya@gmail.com>
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 26, 2024
@sm-sayedi @rajveermalviya
compose_box: Replace compose box with a banner in DMs with deactivate…
1000957 
…d users

Fixes: zulip#675

Co-authored-by: Rajesh Malviya <rajveer0malviya@gmail.com>
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 26, 2024
@sm-sayedi @rajveermalviya
compose_box: Replace compose box with a banner in DMs with deactivate…
208ec67 
…d users

Fixes: zulip#675

Co-authored-by: Rajesh Malviya <rajveer0malviya@gmail.com>
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 26, 2024
@sm-sayedi @rajveermalviya
compose_box: Replace compose box with a banner in DMs with deactivate…
f3fa9b7 
…d users

Fixes: zulip#675

Co-authored-by: Rajesh Malviya <rajveer0malviya@gmail.com>
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 27, 2024
@sm-sayedi @rajveermalviya
compose_box: Replace compose box with a banner in DMs with deactivate…
1d3feb8 
…d users

Fixes: zulip#675

Co-authored-by: Rajesh Malviya <rajveer0malviya@gmail.com>
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 28, 2024
@sm-sayedi @rajveermalviya
compose_box: Replace compose box with a banner in DMs with deactivate…
92c0c7c 
…d users

Fixes: zulip#675

Co-authored-by: Rajesh Malviya <rajveer0malviya@gmail.com>
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 28, 2024
@sm-sayedi @rajveermalviya
compose_box: Replace compose box with a banner in DMs with deactivate…
e5d9552 
…d users

Fixes: zulip#675

Co-authored-by: Rajesh Malviya <rajveer0malviya@gmail.com>
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 29, 2024
@sm-sayedi @rajveermalviya
compose_box: Replace compose box with a banner in DMs with deactivate…
bbfd6e4 
…d users

Fixes: zulip#675

Co-authored-by: Rajesh Malviya <rajveer0malviya@gmail.com>
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 30, 2024
@sm-sayedi @rajveermalviya
compose_box: Replace compose box with a banner in DMs with deactivate…
f4b37c2 
…d users

Fixes: zulip#675

Co-authored-by: Rajesh Malviya <rajveer0malviya@gmail.com>
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Aug 1, 2024
@sm-sayedi @rajveermalviya
compose_box: Replace compose box with a banner in DMs with deactivate…
019a68c 
…d users

Fixes: zulip#675

Co-authored-by: Rajesh Malviya <rajveer0malviya@gmail.com>
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Aug 2, 2024
@sm-sayedi @rajveermalviya
compose_box: Replace compose box with a banner in DMs with deactivate…
060313b 
…d users

Fixes: zulip#675

Co-authored-by: Rajesh Malviya <rajveer0malviya@gmail.com>
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Aug 2, 2024
@sm-sayedi @rajveermalviya
compose_box: Replace compose box with a banner in DMs with deactivate…
6e18c99 
…d users

Fixes: zulip#675

Co-authored-by: Rajesh Malviya <rajveer0malviya@gmail.com>
@gnprice gnprice closed this as completed in 052f203 Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sm-sayedi sm-sayedi

Labels
a-compose Compose box, autocomplete, attaching files/images
Projects
Flutter app
Status: Done
Milestone
M3: Summer 2024
Development

Successfully merging a pull request may close this issue.

compose_box: Replace compose box with a banner in DMs with deactivated users sm-sayedi/zulip-flutter
2 participants
@gnprice @sm-sayedi