Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On failed message send, show error dialog #815

Closed
gnprice opened this issue Jul 16, 2024 · 0 comments · Fixed by #819
Closed

On failed message send, show error dialog #815

gnprice opened this issue Jul 16, 2024 · 0 comments · Fixed by #819
Labels
a-compose Compose box, autocomplete, attaching files/images server-9 Things new in Zulip Server 9.0

Comments

@gnprice
Copy link
Member

gnprice commented Jul 16, 2024

When you hit the send button in the compose box, and the send request fails for whatever reason, we currently drop that error on the floor; we don't show the user any feedback about the failure. We should fix that, by showing an error dialog box.

For examples of how to do this, see the existing call sites of showErrorDialog.

(Historical note: I think the only reason we haven't already done this is that this feature, being so critical to using Zulip, was added early in the prototype before we'd worked out dialog boxes. That's a natural thing to happen, but a bit ironically it means that we've had error handling for a number of less-critical actions for a while without yet having it here.)

This is effectively a simplified version of #720: for this issue, we won't yet make any changes to the compose box and send button, like to give them a "disabled" appearance or keep the text available. Those will be good improvements to make (and #720 tracks making them), but even just showing the error dialog will be an improvement over the status quo.

One effect of this is that until the permission check #791 is implemented, we'll be in much the same position for that feature as zulip-mobile now is (since zulip/zulip-mobile#5878).

Other reports of this issue, indirectly, appear in:

@gnprice gnprice added a-compose Compose box, autocomplete, attaching files/images server-9 Things new in Zulip Server 9.0 labels Jul 16, 2024
@gnprice gnprice added this to the Beta 3: Summer 2024 milestone Jul 16, 2024
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Jul 17, 2024
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-compose Compose box, autocomplete, attaching files/images server-9 Things new in Zulip Server 9.0
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant