-
-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topic autocomplete missing part of touch target on iOS #5486
Comments
Thanks @namse for the report! I reproduce the issue. Specifically:
I think the cause is not likely to be related to the resolved-topic checkmark. The symptom seems to be the same on topics that don't have that, and even when none of the topics in the list have it. |
OK, and with some further testing:
We sent v27.191 to all users on 2022-09-08, a few days before this issue was filed. So that fits very neatly with the mention of it happening "very recently". @chrisbobbe would you take a look at debugging this? I think the next step is to bisect to find where the regression happened (or if you have a guess as to what caused the issue, then to check that guess directly.) |
It appears that the react-native-gesture-handler upgrade in that commit was a factor, by changing React Navigation's behavior so that it closes the keyboard for the swipe-right-to-go-back gesture at the moment you press the screen, instead of when you actually start swiping. I expect a fix in @react-navigation/stack 6.1.0, from commit react-navigation/react-navigation@5a19877. I did a quick manual cherry-pick of that commit (it's a one-line change) in node_modules at Greg, do we think we could take that @react-navigation/stack 6.1.0 upgrade soon, or should we look at other options, like examining the reason for the gesture-handler upgrade for a possible revert, etc.? |
We just had another report of this issue. |
(Much like we did for @react-navigation/bottom-tabs in c0b17bd.) To get chrisbobbe/react-navigation@a588dcee9, which I've published to NPM in @zulip/react-navigation-stack@5.14.10-0.zulip.1. It cherry-picks react-navigation/react-navigation@5a1987708, which fixes zulip#5486, as noted there: zulip#5486 (comment) So this fix will become unnecessary when we're on React Navigation 6; that's issue zulip#4936. Tested the bugfix on my iPhone 13 Pro running iOS 16.1, with and without "Debug with Chrome". The bug was fixed, and back navigation worked as expected, both with the swipe gesture and the back button. Fixes: zulip#5486
Hi. Very recently when I tab the topic, it just ignores my input.
Upload.from.GitHub.for.iOS.MOV
I'm not sure why it happened.
The text was updated successfully, but these errors were encountered: