deps: Temporarily use fork for @react-navigation/stack #5682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good, thanks! Merging. |
(Much like we did for @react-navigation/bottom-tabs in c0b17bd.) To get chrisbobbe/react-navigation@a588dcee9, which I've published to NPM in @zulip/react-navigation-stack@5.14.10-0.zulip.1. It cherry-picks react-navigation/react-navigation@5a1987708, which fixes zulip#5486, as noted there: zulip#5486 (comment) So this fix will become unnecessary when we're on React Navigation 6; that's issue zulip#4936. Tested the bugfix on my iPhone 13 Pro running iOS 16.1, with and without "Debug with Chrome". The bug was fixed, and back navigation worked as expected, both with the swipe gesture and the back button. Fixes: zulip#5486
gnprice
force-pushed
the
pr-ios-left-touch-target
branch
from
77c9eda to
705c0b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Much like we did for @react-navigation/bottom-tabs in c0b17bd.)
To get chrisbobbe/react-navigation@a588dcee9, which I've published to NPM in @zulip/react-navigation-stack@5.14.10-0.zulip.1.
It cherry-picks react-navigation/react-navigation@5a1987708, which fixes #5486, as noted there:
#5486 (comment)
So this fix will become unnecessary when we're on React Navigation 6; that's issue #4936.
Tested the bugfix on my iPhone 13 Pro running iOS 16.1, with and without "Debug with Chrome". The bug was fixed, and back navigation worked as expected, both with the swipe gesture and the back button.
Fixes: #5486