Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "private messages" to "direct messages" #5731

Closed
alya opened this issue May 12, 2023 · 1 comment · Fixed by #5735
Closed

Rename "private messages" to "direct messages" #5731

alya opened this issue May 12, 2023 · 1 comment · Fixed by #5735
Assignees
Labels
P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.

Comments

@alya
Copy link
Collaborator

alya commented May 12, 2023

In zulip/zulip#24224 and follow-up work, we renamed "private messages" to "direct messages" in the web app. We should do the same in the mobile app. This issue is specifically for user-facing stings.

The mobile instructions on /help/direct-messages and in /help/include/send-group-dm.md will need to be updated accordingly, either as part of this issue, or as an immediate follow-up.

@alya alya added webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity. P1 high-priority labels May 12, 2023
@gnprice
Copy link
Member

gnprice commented May 12, 2023

This issue is specifically for user-facing strings.

Just to underline this part: let's defer any renames or other refactoring, leaving non-user-facing uses of "private" alone for now.

@chrisbobbe chrisbobbe added the server release goal Things we should try to coordinate with a major Zulip Server release. label May 18, 2023
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue May 23, 2023
As mentioned in the issue, there are various variable names that
still use "private messages"; we're leaving those be for now.

PR zulip#5728 is open for a related API migration: to use 'direct'
instead of 'private' in POST /messages, when supported.

Fixes: zulip#5731
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue May 25, 2023
As mentioned in the issue, there are various variable names that
still use "private messages"; we're leaving those be for now.

PR zulip#5728 is open for a related API migration: to use 'direct'
instead of 'private' in POST /messages, when supported.

Fixes: zulip#5731
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants