ui: Rename "private messages" / "PMs" to "direct messages" / "DMs", etc. #5735
Conversation
chrisbobbe
added
P1 high-priority
server release goal
src/settings/SettingsScreen.js
Outdated
| 'Messages will be automatically marked as read only when viewing a single topic or private message conversation.', | ||
| 'Messages will be automatically marked as read only when viewing a single-topic or direct-message conversation.', |
There was a problem hiding this comment.
This revised text suggests these are two kinds of conversations, and there are other kinds of conversations. I don't think that's a way we normally use "conversation".
The original text was intended to mean "viewing a single topic (as opposed to a whole stream), or viewing a (single) PM conversation". Could perhaps be clarified by adding one hyphen: "direct-message conversation" (or previously could have been "private-message conversation"). Or could expand it more wordily if that doesn't seem clear.
In the interest of getting this rename in, probably best to minimize the other wording changes and leave those for a possible followup.
There was a problem hiding this comment.
Ah OK, right! Thanks for the catch; I'll make it so "private" to "direct" is the only change here.
chrisbobbe
force-pushed
the
pr-ui-rename-pm-dm
branch
from
a67ed80
to
3fbdca4
Compare
As mentioned in the issue, there are various variable names that still use "private messages"; we're leaving those be for now. PR zulip#5728 is open for a related API migration: to use 'direct' instead of 'private' in POST /messages, when supported. Fixes: zulip#5731
chrisbobbe
force-pushed
the
pr-ui-rename-pm-dm
branch
from
3fbdca4
to
63a917b
Compare
|
Thanks for the review! Merged, with that fix. |
As mentioned in the issue, there are various variable names that still use "private messages"; we're leaving those be for now.
PR #5728 is open for a related API migration: to use 'direct' instead of 'private' in POST /messages, when supported.
Fixes: #5731