Follow some Expo 43 -> 44 template-app changes, belatedly #5550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Expo This belatedly follows a change in Expo's template app, templates/expo-template-bare-minimum. The change was made in expo/expo@2a0079132, and we missed it in the Expo 44 upgrade (zulip#5441) because Expo's upgrade guide forgot about it. See discussion of this and other changes that were missed: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/Expo.2044.20small.20things/near/1452850 This seems to fix a bug I've observed on the office Android device (Samsung Galaxy S9 running Android 9), where if I exit the app via the back button, then re-enter the app, the state gets reset such that we register for a new event queue.
This belatedly follows a change in Expo's template app, templates/expo-template-bare-minimum. The change was made in expo/expo@d20594b55 and expo/expo@b59dbc4d8, and we missed it in the Expo 44 upgrade (zulip#5441) because Expo's upgrade guide forgot about it. See discussion of this and other changes that were missed: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/Expo.2044.20small.20things/near/1452850 From reading the Expo commits and their associated PRs, I don't feel like I understand the purpose of this change. But Greg says it doesn't seem unreasonable: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/Expo.2044.20small.20things/near/1458126 And nothing seemed broken when I tested the change on my iPhone 13 Pro running iOS 16.1. In particular, since we have a comment mentioning social auth, I tested that I could still log in with Google, and that worked. Those Expo commits also touched a different method, meant to implement an Apple feature called "Handoff": https://support.apple.com/en-us/HT209455 Here, we ignore the changes to that method; we haven't implemented it, and while Handoff could sometimes be useful, it isn't a priority. Also, Greg is skeptical about Expo's template-app changes to that method.
|
Thanks for taking care of this! Looks good -- merging. |
gnprice
force-pushed
the
pr-expo-44-audit
branch
from
042f025
to
3fa18f3
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that when I did the Expo 44 upgrade in #5441, there were a few changes to Expo's template app that I didn't consider, because they weren't mentioned in the upgrade guide and I guess I didn't go and look at the actual commits.
Details in chat, including the list of commits and how we filtered them down to these two changes.