Handle inline video previews #5791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This README file accurately described how the build worked when it was written. But then a few months later we changed that, in 0fb3d16, and we didn't update the README accordingly. The automatic way seems like a nicer developer experience. Probably what this script ought to do is to ask Git for the list of files, and copy those, in order to make it automatic while not getting fooled by extraneous files in the directory. For this legacy codebase, though, the way it actually works will be fine. Just fix the README to reflect that; and then update the list to reflect the one change it should have gotten, from commit ae7ad99 a few more months later.
gnprice
added
a-message list
a-lightbox
server release goal
|
Thanks, LGTM! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5781